[6.1.0] {{on 'click'}}, <LinkTo> and <menu.linkTo> in dropdown menus dysfunctional about ember-bootstrap

[SanderKnauff]

I can confirm that the <a {{on 'click' this.onclickAction}}> case is broken. I will probably look into this tomorrow.
@IBue, LinkTo and menu.linkTo seem to work, did you mean that it only works due to the href?

@simonihmig If I fix this, should we release a 6.1.1 with only this fix or a 6.2.0 that also includes the current Typescript work?

[jelhan]

If I fix this, should we release a 6.1.1 with only this fix or a 6.2.0 that also includes the current Typescript work?

I don't see a risk releasing what has been finished from the TypeScript conversion together with this bug fix. I would just not delay releasing the bug fix until TypeScript conversion is fully done. We should document in changelog that TypeScript conversion is on-going process and types published are not considered as stable (and complete).

[simonihmig]

Yeah, I agree. I think we can label all TS migration as internal, so it does not show up as a feature in the changelogs. And only announce this as a stable when we are ready?

[jelhan]

I think we can label all TS migration as internal, so it does not show up as a feature in the changelogs. And only announce this as a stable when we are ready?

I would mention them in changelog for marketing purposes. It may motivate people to step in and help getting it over the finish line.

[simonihmig]

Yeah, but this is happening with an internal label. Isn't that enough? As enhancement would suggest it to be a new public feature, that justifies a minor version bump, which is what I wanted to prevent...

[jelhan]

Yeah, but this is happening with an internal label. Isn't that enough? As enhancement would suggest it to be a new public feature, that justifies a minor version bump, which is what I wanted to prevent...

Got it. I don't mind much to be honest. I think adding a sentence on current TypeScript status on the top of the changelog entry is likely more effective.

[SanderKnauff]

@IBue This has been fixed in 6.2.0.
Could you please try it out and see if the issue is solved for you as well?

[IBue]

👍 6.2.0 nails it for ember-source 4.8, 4.12, 5.4
…and there is a new test case for it.