GithubHelp home page GithubHelp logo

Comments (7)

LevelbossMike avatar LevelbossMike commented on August 20, 2024

I guess broccoli-asset-rev does not fingerprint .ico files by default. You have to add it to the extensions-array in the fingerprint options. Then your favicon should be fingerprinted correctly and should also have the cdn url prepended.

You can have a look at options for broccoli-asset-revs (the addon responsible for fingerprinting assets for a production build) here:

https://github.com/rickharrison/broccoli-asset-rev#options

After that it should be fine to upload your favicon to s3 and you can also update it, as it will be fingerprinted as any other asset.

from ember-cli-deploy-s3.

florent-blanvillain avatar florent-blanvillain commented on August 20, 2024

But would'nt it be better to let those assets be served by the main domain ?

from ember-cli-deploy-s3.

LevelbossMike avatar LevelbossMike commented on August 20, 2024

Well that depends what kind of deployment flow you are using. In my case the ember app would be the main domain. Sorry I thought you were having trouble with the fingerprint settings.

If you want to exclude the ico file from the s3-upload you could just remove the file extension from the filePattern option for s3:

https://github.com/ember-cli-deploy/ember-cli-deploy-s3#filepattern

from ember-cli-deploy-s3.

florent-blanvillain avatar florent-blanvillain commented on August 20, 2024

If I exclude *.ico files, ember will just route /favicon.ico to /public/favicon.ico ?
The ember app is my main domain (as I understand it). See : provideup.com

from ember-cli-deploy-s3.

florent-blanvillain avatar florent-blanvillain commented on August 20, 2024

Sorry, as you can see I'm a little lost here :-)
I think the problem is with my node server :-)

from ember-cli-deploy-s3.

LevelbossMike avatar LevelbossMike commented on August 20, 2024

Ember won't redirect a request for your favicon. The user's browser will just load the favicon based on what's the path for the favicon in the bootstrap index.html that ember-cli creates for you when running ember build. So if you want to show a favicon with a different path as the default you can just change the path to the favicon in index.html and it should work. So just change the path in index.html in your app folder and don't add ico files to your broccoli-asset-rev settings and it should work as you want it to.

Hope that helps.

from ember-cli-deploy-s3.

florent-blanvillain avatar florent-blanvillain commented on August 20, 2024

You're right, indeed Ember has nothing to do with the routing of static ressources !
I think I will use my node server to proxy those ressources to /.
Thank you

from ember-cli-deploy-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.