>= 1.10 Doesn't Respect `liveReloadBaseUrl` about ember-cli-inject-live-reload

[rwjblue]

thank you for the awesome write up, would you mind adding another scenario to our tests!

Something like this one:

ember-cli-inject-live-reload/tests/inject-live-reload-test.js

Lines 90 to 96 in 6177d46

	it('liveReloadPort and port are different', assert => {
	options.liveReloadPort = '35729';
	let script = InjectLiveReload.dynamicScript(options);
	let actual = getScriptSrc(script);
	assert.strictEqual(actual, 'http://localhost:35729/_lr/livereload.js?port=35729&host=localhost&path=_lr/livereload');
	});

But with the options that you were using? Presumably it fails now (due to not incorporating the port) but having the test helps us 1) make sure we don’t regress in the future, 2) that I actually understand the problem properly 😜

[jherdman]

Sure thing! I've made branch here https://github.com/jherdman/ember-cli-inject-live-reload/tree/issue-68 but I can't seem to open a PR to this repo. Can't say I've had that happen before 😢

[jherdman]

PR opened! It looks like I was affected by the Github outage.

[rwjblue]

I think this was fixed in #113 (please double check).

[jherdman]

Worked like a charm!

[rwjblue]

Thanks for confirming!