Handle bower/git install errors about ember-cli

[stefanpenner]

I think we should move the bower install phase out of the npm install postinstall hook, and into the cli directly.

In addition we can likely test for this failure and emit a useful error message. (Ideally this is something bower will solve)

[stefanpenner]

we should add a trouble shooting section to the guides, to explain this:

(cc @twokul )

[twokul]

@stefanpenner confirm

[mauriciomdea]

I got another git error while creating/initializing a new app:

Installing packages for tooling via npm...
npm ERR! git fetch -a origin (https://github.com/joefiorini/insight.git) error: cannot open FETCH_HEAD: Permission denied
Error: Command failed: error: cannot open FETCH_HEAD: Permission denied

stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
Error: ENOENT, lstat '/Users/mma/src/ember-test/node_modules/broccoli-es6-import-validate/node_modules/lodash/lodash.js'

Dunno if I open another issue for this.

[stefanpenner]

@brandnewcode are you behind a firewall?

[MajorBreakfast]

Will be no problem after we switch to @twokul 's leek.

[mauriciomdea]

@stefanpenner no firewalling and other git commands and repos are working normally in my shell, including cloning that repo in the error message.

[mauriciomdea]

Ok, I upgraded all my stack (node, npm, git, etc) and it worked. But the problem was ocurring on the Insights installation, which I didn't allow this time.

[stefanpenner]

strange... the next version of cli doesn't use insight anymore, rather @twokul's leek, which is simpler and provides more flexibility, If we find issues with it we can alsofix it quickly

[stefanpenner]

we are likely doing as good as a job as we can. I have been speaking and working with npm + bower folk to improve the quality of error messages from there tooling. Beyond that, I am unsure what we can do.

[givanse]

In 0.29 I just got:

stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
Error: ENOENT, lstat

The interesting part is that the error was thrown when I was in a FAT32 partition, everything worked well in a EXT4 partition. At least thats the only difference I noticed between my two scenarios.

[tvararu]

Sorry for resurrecting an old bug.

@stefanpenner: So you're saying that the error message is actually coming from npm/bower? Is it possible to wrap the child processes and conditionally display a smarter message, sending people to the troubleshooting section in the docs?

Anyway, I encountered this issue on a corporate wi-fi network that blocks port 22. Here's the truncated output:

$ ember new my-new-app
version: 0.1.15
Could not find watchman, falling back to NodeWatcher for file system events
installing
  create .bowerrc
  ...
  create vendor/.gitkeep
Installed packages for tooling via npm.
Failed to execute "git ls-remote --tags --heads git://github.com/ember-cli/ember-cli-test-loader.git", exit code of #128
Error: Failed to execute "git ls-remote --tags --heads git://github.com/ember-cli/ember-cli-test-loader.git", exit code of #128
    at createError (/usr/local/lib/node_modules/ember-cli/node_modules/bower/lib/util/createError.js:4:15)
    at ChildProcess.<anonymous> (/usr/local/lib/node_modules/ember-cli/node_modules/bower/lib/util/cmd.js:102:21)
    at ChildProcess.emit (events.js:98:17)
    at maybeClose (child_process.js:766:16)
    at Socket.<anonymous> (child_process.js:979:11)
    at Socket.emit (events.js:95:17)
    at Pipe.close (net.js:466:12)

[tvararu]

I've actually taken a proper look into it, and it's actually very easy to hook into lib/tasks/bower-install.js and add some additional prose .on('error'). I'll work on writing a test and see if I can get a PR in.