ember-typescript-cli v2 about ember-decorators

[XuluWarrior]

@simonihmig That was very helpful
I found that our code also has quoted properties.

A quick hack to transformer-legacy.js "fixes" this. But I don't know enough Babel to know what a real fix would be.

    path.replaceWith(_core().types.callExpression(state.addHelper("initializerDefineProperty"), [_core().types.cloneNode(path.get("left.object").node), _core().types.stringLiteral(path.get("left.property").node.name), _core().types.cloneNode(path.get("right.arguments")[0].node), _core().types.cloneNode(path.get("right.arguments")[1].node)]));

->

    path.replaceWith(_core().types.callExpression(state.addHelper("initializerDefineProperty"), [_core().types.cloneNode(path.get("left.object").node), _core().types.stringLiteral(path.get("left.property").node.name || path.get("left.property").node.value), _core().types.cloneNode(path.get("right.arguments")[0].node), _core().types.cloneNode(path.get("right.arguments")[1].node)]));

Unfortunately, I'm now getting runtime issues which I'm looking into now.

[XuluWarrior]

One thing I have noticed is that a number of our ember add-on dependencies using ember-cli-babel@^6. So while the top level installed version of ember-cli-babel is 7.7.3, some add-ons have a private dependency on 6.18.0.

Could this be a factor in my issue?

[simonihmig]

Seeing the same, after upgrading e-d from 5.x to 6.0 (and going back to stage 1 decorators). Seems to be related to having a quoted property, at least for me...

This fails the build with that TypeError: Property value expected type of string but got null error:

  @attribute
  'data-test-foo' = true;

While this works:

  @attribute
  dataTestFoo = true;

[buschtoens]

I would bet that usage of ember-cli-typescript is not relevant here, but that this is a bug in the legacy decorators implementation of babel.

[dfreeman]

It looks like there's an issue for this in the Babel repo, but it hasn't gotten any love yet babel/babel#10059

[fpauser]

Note: babel/babel#10059 was fixed with babel/babel#10578 (support string literal properties)