Broken on latest canary about ember-engines

[casimcdaniels]

@dgeb

Any updates? Cloned the ember-engine-demo repo and upon running ember s I get the following error:

Uncaught Error: Could not find module ember-views/views/select

[rwjblue]

Awesome, thank you for reporting. I'll to dig into tonight/tomorrow morning.

[trentmwillis]

Out of curiosity, how important is it to run on Canary? Since this addon imports the Engine and other classes using emberRequire everything works fine on the current Release or Beta builds. Is the Canary recommendation simply to acknowledge that this has some cutting edge APIs?

Edit: also if running on Canary is important, should we add a note in the README saying to enable the ember-application-engines flag?

[dgeb]

@trentmwillis We are recommending Canary until this addon only uses Ember's public APIs. Until then, we'll be moving any custom overrides from this addon into Ember Core gradually, so we can only recommend use of Ember Canary for Ember Engines Canary. With that said, there's a good chance that particular versions of this addon will end up being compatible with particular Beta and Release builds of Ember itself.

[dgeb]

@cmcdaniels Yeah, there have been quite a few changes in Ember Canary lately. I started working on an upgrade to this addon a few days ago, but it's not quite green yet.

[trentmwillis]

I looked into this a bit more, in hopes of unblocking some efforts to use a newer version of canary and it seems there are two core issues:

1. Outlets now need a template registered otherwise they don't render anything, and
2. Some registrations are now "private" which means looking them up by the normal string fails.

Unfortunately, looks like both of these require knowledge of truly private constructs in Ember, so I only verified fixes by monkeypatching.

[rwjblue]

Awesome, thank you @trentmwillis!

---

The first one can be solved with something like this around here:

const topLevelViewTemplate = emberRequire('ember-htmlbars/templates/top-level-view');

then registering around here.

---

The second can be solved via annoyingly grabbing the private symbol and registering:

const P = emberRequire('container/register', 'privatize');

And registering the same...

[trentmwillis]

Ah cool, forgot you can use the emberRequire to get internal packages. I'll try to put together a PR.

[rwjblue]

Shhh, don't tell anyone 😉

[rwjblue]

Fixed by #83 and #82