Comments (7)
Help me to understand your use case, because it seems to me that noSwiping
and allowSwipeToPrev/allowSwipeToNext
options are mutually exclusive as they naturally would conflict. Is there a situation you need to use both?
I guess what I'm getting at is that it would be easier for me to debug the issue once your example eliminates the possibility of incompatible settings.
from ember-cli-swiper.
Maybe I don't understand how it's intended to work. Which if any of these scenarios are valid?
{{#swiper-container
noSwiping=true
noSwipingClass='swiper-slide'
allowSwipeToPrev=false
allowSwipeToNext=false
}}
{{#swiper-container
noSwiping=false
noSwipingClass=null
allowSwipeToPrev=true
allowSwipeToNext=true
}}
{{#swiper-container
noSwiping=false
noSwipingClass=null
allowSwipeToPrev=false
allowSwipeToNext=true
}}
from ember-cli-swiper.
1 and 2 just look redundant to me. Far simpler to just do {{swiper-container noSwiping=true}}
and {{swiper-container noSwiping=false}}
respectively.
3 noSwiping=false
conflicts with allowSwipeToNext=false
rather the component should be defined as:
Since you need more fine grained control than noSwiping
provides.
from ember-cli-swiper.
So then this scenario is not possible, correct?
Dynamically switch between these two conditions:
noSwiping is true only for "class1"
allowSwipeToNext is true (for classes other than "class1")
allowSwipeToPrev is false for all classes
noSwiping is false
allowSwipeToNext is true
allowSwipeToPrev is false
from ember-cli-swiper.
While it's entirely possible to provide all those options together, all I'm saying is it doesn't make any sense to me why someone would do so when you could just do:
Whereas when you do:
You're basically saying: "The slider can swipe left and right... and swiping is disabled" those 2 instructions are obviously in conflict and which instruction wins is 100% up to how Swiper.js implements it and has nothing to do with this addon. This why I want us to stop using them together so we can get to the bug you've reported: that computed properties are not updating the container.
from ember-cli-swiper.
What I thought I could say is "Allow swiping for all classes except X". It seems this is not true.
from ember-cli-swiper.
Fair enough, I'm going to close this for now. If you find that computed properties are not updating the swiper-container
please feel free to reopen the issue.
from ember-cli-swiper.
Related Issues (20)
- Issues with actions dying when loop is enabled HOT 5
- Bug: Loading lazy load background images HOT 2
- Prev-Next Navigation as Action Outside of {{#swiper-container}} HOT 3
- Swiper slides randomly stop working HOT 1
- forceUpdate not resetting current slide index HOT 3
- Help Creating Large Carousel With Dynamic Content HOT 6
- currentSlide does not update when removing the current viewing item HOT 9
- Having trouble with slidesPerView: "auto" HOT 5
- DEPRECATION: @component:swiper-container::ember404>#options computed property was just overriden HOT 1
- Duplicate ids with loop option HOT 6
- slideNext() is not a function HOT 3
- Ember 3.22 error on destroy HOT 6
- Screen breakpoints for slidesPerView
- Custom Pagination and Navigation HOT 2
- Deprecation warning: `hasPagination` property path was used in a template... (ID: `this-property-fallback`)
- Ember Global deprecation warning due to old version of ember-cli-babel HOT 1
- Critical vulnerability in npm install HOT 2
- Deprecation warning for mouseEnter/mouseLeave component methods
- Doesn't work on Ember 4.1.0 HOT 5
- make disabled navigation buttons have aria-disabled attribute and remove tabindex if button is disabled to meet accessibility guidelines
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-swiper.