Comments (2)
Currently, as the rule doc says, this rule checks any text nodes for excess whitespace, including text inside or outside attributes. But I think it's a fair question to ask if the rule should be checking the values of arbitrary attributes. Arguably, the class
attribute could be fair-game for an excess whitespace check, as it's an attribute we know shouldn't have (or at least doesn't need) excess whitespace in it, but attribute values aren't used for the page layout, so checking this may not align with the goal of the rule.
I didn't immediately see a justification for this behavior in the original rule PR #819. Maybe @MelSumner has some context on whether this is intended behavior.
from ember-template-lint.
@bmish I'd be okay with excluding attribute values from these checks, that seems reasonable.
from ember-template-lint.
Related Issues (20)
- Incorrect no-redundant-role on img HOT 5
- Improve builtin-component-arguments rule to lint against "radio" inputs HOT 1
- ARIA-compliant disabled link communication raises errors on default config
- allow no-invalid-link-text to be configured for custom link component names
- Drop Recommended Rules for Deprecated Ember 3.x Features HOT 4
- New rule: no-jsx-attributes
- New rule: No chaining `this` to itself HOT 2
- [no-action-on-submit-button] Do not handle `<form method="dialog">`
- Autofix of block-indentation crash
- require-input-label false positive HOT 3
- Revamped gjs/gts support HOT 2
- [gjs]: no-unknown-arguments-for-builtin-components incorrectly assumes an `<Input>` is the ember `<Input>`
- [gjs]: require-input-label incorrectly assumes an `<Input>` is the ember `<Input>`
- Migrate off Jest HOT 3
- no-black-params-for-html-elements failes with dot-separated angle bracket invocation
- Plan v7 Release
- overrides do not apply to gts
- Running `--fix` when enabling `attribute-order` rule hangs process HOT 1
- Bug: autofix of `attribute-order` removes empty string attribute/argument values HOT 1
- Contradictions from no-potential-path-strings and no-unnecessary-curly-strings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-template-lint.