GithubHelp home page GithubHelp logo

Comments (2)

bmish avatar bmish commented on June 19, 2024

Currently, as the rule doc says, this rule checks any text nodes for excess whitespace, including text inside or outside attributes. But I think it's a fair question to ask if the rule should be checking the values of arbitrary attributes. Arguably, the class attribute could be fair-game for an excess whitespace check, as it's an attribute we know shouldn't have (or at least doesn't need) excess whitespace in it, but attribute values aren't used for the page layout, so checking this may not align with the goal of the rule.

I didn't immediately see a justification for this behavior in the original rule PR #819. Maybe @MelSumner has some context on whether this is intended behavior.

from ember-template-lint.

MelSumner avatar MelSumner commented on June 19, 2024

@bmish I'd be okay with excluding attribute values from these checks, that seems reasonable.

from ember-template-lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.