store.load doesn't update its record about data

[rague]

It seems that it's expected with fixtures: you can't load it twice. (handled by fixtures.hasLoaded property - fixture_adapter.js).

[guilhermeaiolfi]

hasLoaded goes back to undefined before setting the new data in App.Person.FIXTURES. Other than that, the code is shared between all adapters.

[guilhermeaiolfi]

So, I looked it over and it seems that in store.updateModelArray we have:

if (shouldBeInArray && !alreadyInArray) {
      modelArrays.add(array);
      content.pushObject(clientId);
    } else if (!shouldBeInArray && alreadyInArray) {
      modelArrays.remove(array);
      content.removeObject(clientId);
    }

but when it should update the data it has shouldBeInArray as true and alreadyInArray as true also. And this case isn't being considered in the code.

But I'm not sure how I should proceed here. "content" seems to have a list of indexes but what about "modelArrays"? I'm not sure what it suppose to be or do. I know it's a SC.OrderedSet but in my example modelArrays.list has 2 objects and there is 4 in my store. I need some tips here. Thanks.

[guilhermeaiolfi]

I've done something that seems to work:

updateModelArray: function(array, filter, type, clientId, hash) {
    var shouldBeInArray;

    if (!filter) {
      shouldBeInArray = true;
    } else {
      shouldBeInArray = filter(hash);
    }

    var content = get(array, 'content');
    var alreadyInArray = content.indexOf(clientId) !== -1;

    var modelArrays = this.modelArraysForClientId(clientId);

    if (shouldBeInArray && !alreadyInArray) {
      modelArrays.add(array);
      content.pushObject(clientId);
    } else if (!shouldBeInArray && alreadyInArray) {
      modelArrays.remove(array);
      content.removeObject(clientId);
    } else if (shouldBeInArray && alreadyInArray) {
        var models = get(this, 'models');
        this.didUpdateModel(models[clientId], hash);
    }
  },

The last "else if" being the relevant part.

What do you think?

[guilhermeaiolfi]

It seems that bbf044b should fix this as well. I'll try that monday.

[wycats]

I'm closing this ticket. If it's still an issue, please let me know.

[guilhermeaiolfi]

Well, I updated the jsfiddle to use the last changes: http://jsfiddle.net/5n2LU/8/

But it doesn't work yet.

findMany calls loadMany internatlly in the fixtureAdapter, so it should update those records in the store, but that's not happening.

[wycats]

The semantics of findMany are that if the IDs are already in the store, the store doesn't go back to the adapter to get more data.

[guilhermeaiolfi]

Al'right, but loadMany shouldn't update the store?

Even tho there is a if (fixtures.hasLoaded) { return; } in the code, hasLoaded is undefined in the jsfiddle example in both findMany calls.

findMany will call find that will call loadMany. Here it is the code I'm talking about:

find: function(store, type, id) {
    var fixtures = type.FIXTURES;

    ember_assert("Unable to find fixtures for model type "+type.toString(), !!fixtures);
    if (fixtures.hasLoaded) { return; }

    setTimeout(function() {
      store.loadMany(type, fixtures);
      fixtures.hasLoaded = true;
    }, 300);
  }

[guilhermeaiolfi]

I really think the else if that I mentioned earlier in this thread, inside the updateModelArray function, is a case that is not being dealt and seems the source of this problem.

[guilhermeaiolfi]

Since another person in the IRC channel had this problem:

how can i refresh data of ember-data?? i loaded an array of items with find and now i would like to refresh them?
should i use findMany?? calling again findAll does not request anything, i assumed is returning the cache```

He managed to update the records:

for findAll i fixed by Yn.store.typeMapFor(Yn.Product).findAllCache = null;```

But that doesn't seem right. Is it?