GithubHelp home page GithubHelp logo

Comments (10)

runspired avatar runspired commented on July 28, 2024 1

should be resolved on main. Will result in the module still being present unfortunately, though empty.

from data.

runspired avatar runspired commented on July 28, 2024

hrm, this one is kinda tricky because I don't think we can safely add it as an app re-export and support configuring it correctly. With it being a v2-addon now its likely you should have to explicitly add it to your build.

from data.

patricklx avatar patricklx commented on July 28, 2024

the v2 addons do have app re exports with the provided rollup addons from embroider.
Can you not use those?

from data.

Baltazore avatar Baltazore commented on July 28, 2024

Hey @patricklx if you can point me to that I can spend some1 time adding those if you ok with it @runspired

from data.

patricklx avatar patricklx commented on July 28, 2024

Sure. It's in the default blueprint:
https://github.com/embroider-build/addon-blueprint/blob/cb4d7eee319b15cd2aae822653009a96d10baab4/files/__addonLocation__/rollup.config.mjs#L29

from data.

patricklx avatar patricklx commented on July 28, 2024

I think it should have at least a deprecate step. So it could also be part of -ember-data package. With some macro condition?
https://github.com/emberjs/data/tree/main/packages/-ember-data/app

from data.

runspired avatar runspired commented on July 28, 2024

We can't use app re-export from the V2 add-on at all, we could maybe guard the import in -ember-data but regardless we'll have to break the existing config setting

from data.

patricklx avatar patricklx commented on July 28, 2024

Why not? Some constraints by ember data internals?

from data.

runspired avatar runspired commented on July 28, 2024

@patricklx because we have an existing config setting used to keep it in the build in v1, the default is that its not included in the build, and vite/embroider don't have a clean production-only-import concept so I'm not sure the path forward here.

from data.

patricklx avatar patricklx commented on July 28, 2024

Thanks πŸ‘.
Will this be back ported to 5.3 lts?

from data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.