GithubHelp home page GithubHelp logo

Comments (17)

machty avatar machty commented on May 16, 2024

I like that, though the View Tree icon seems pretty unrepresentative

from ember-inspector.

teddyzeenny avatar teddyzeenny commented on May 16, 2024

Seems good to me. @wycats @jongd thoughts?

from ember-inspector.

wycats avatar wycats commented on May 16, 2024

I like the look. Agreed that we could use better icons.

from ember-inspector.

nummi avatar nummi commented on May 16, 2024

Totally agree about the icons. I'm useless with the pen tool in Adobe illustrator so I snagged those from Pictos. http://pictos.cc. I'll look for alternatives.

from ember-inspector.

nummi avatar nummi commented on May 16, 2024

Better direction? Should the routes icon represent URL or state?

icons

from ember-inspector.

machty avatar machty commented on May 16, 2024

I like the views icon a lot. I also really like the /# routes one since I think everyone will immediately know exactly what it is. I'm only somewhat hesitant because it refers to the somewhat outdated hash location approach, but I think that minor quibble is outweighed by how immediately obvious the icon is, so I'm all for it.

from ember-inspector.

locks avatar locks commented on May 16, 2024

for a lack of better words: πŸ‘

@machty one sort of alternative I could see would be /:id but that longer and not as striking. I think the hash location is fine, isn't it still the default location for ember.js?

from ember-inspector.

jemgold avatar jemgold commented on May 16, 2024

I'm torn between wanting to use Helvetica because it's nice and using Verdana because it fits in with Inspector.

I think the glyph of the hash could use some workβ€”it's a little tallβ€”but I love the metaphor :)

from ember-inspector.

nummi avatar nummi commented on May 16, 2024

Use Verdana for the sidebar and keep Helvetica for the main content?

...or is it Lucida Grande?

from ember-inspector.

nummi avatar nummi commented on May 16, 2024

web2

from ember-inspector.

nummi avatar nummi commented on May 16, 2024

I also tweaked the close button. It's a little bigger with a times symbol in place of the letter x.

New on top:
close

from ember-inspector.

nummi avatar nummi commented on May 16, 2024

@jongd, @machty Matching the inspector looks nice to me. Thoughts?
routes

from ember-inspector.

locks avatar locks commented on May 16, 2024

NICE

from ember-inspector.

ebryn avatar ebryn commented on May 16, 2024

πŸ‘

On Wed, Jul 24, 2013 at 6:16 PM, Jerry Nummi [email protected]:

@jongd https://github.com/jongd, @machty https://github.com/machtyMatching the inspector looks nice to me. Thoughts?
[image: routes]https://f.cloud.github.com/assets/3692/852595/7bbd3c32-f4b6-11e2-91de-ddd0c534b7d0.png

β€”
Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-21523389
.

from ember-inspector.

wycats avatar wycats commented on May 16, 2024

Awesome! This is basically what I had in mind when I proposed the feature.

SHIPIT!

from ember-inspector.

machty avatar machty commented on May 16, 2024

Looks good.

from ember-inspector.

teddyzeenny avatar teddyzeenny commented on May 16, 2024

Closing in favor of #27

from ember-inspector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.