GithubHelp home page GithubHelp logo

Comments (8)

rwjblue avatar rwjblue commented on August 16, 2024

I would use moduleFor('model:post') in a non-ED scenario.

We can provide a nice helpful assertion though, when you call moduleForModel on a non-ED model, what is the "proper" way to detect if a given factory is an Ember Data model?

from ember-test-helpers.

fivetanley avatar fivetanley commented on August 16, 2024

store.modelFactoryFor('post') instanceof DS.Model ?

from ember-test-helpers.

walter avatar walter commented on August 16, 2024

👍 for implementing something that is agnostic. I'm using ember-orbit with ember-mocha and was surprised by describeModel (which wraps moduleForModel) breaking on the ED dependency.

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

We'd happily review a pull request with a proposed solution.

from ember-test-helpers.

walter avatar walter commented on August 16, 2024

Thx @rwjblue, I appreciate your and the rest of contributors' work on this.

I realize I'm not contributing much by simply adding my voice in support of the issue, but the intention is to show that there people who would like this, too.

If I had the means to add a PR for this right now, I would. I'm a long time open source maintainer myself and I realize how much more valuable contributed code is. Having said that, I do believe it is perfectly valid to add to a project by voicing your needs. You, of course, have no obligation to implement what I ask for. I do not feel entitled to anything in regards to the project.

Hey, at least I didn't create a NEW issue without searching existing issues that address my concerns first!

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

I am very sorry if that last comment came off as snarky or negative. I was basically saying that I would definitely be open to a fix, just haven't had time (or a personal need) to dig into it myself yet.

from ember-test-helpers.

walter avatar walter commented on August 16, 2024

All cool. No worries. I was just leaving a little something behind to show that I appreciate the work on this instead of just being a help vampire (can't think of what the OSS equivalent is at the moment).

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

This should be addressed when using the new testing APIs provided by ember-qunit (e.g. moduleForModel is no longer "a thing").

Closing....

from ember-test-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.