Comments (8)
I would use moduleFor('model:post')
in a non-ED scenario.
We can provide a nice helpful assertion though, when you call moduleForModel
on a non-ED model, what is the "proper" way to detect if a given factory is an Ember Data model?
from ember-test-helpers.
store.modelFactoryFor('post') instanceof DS.Model
?
from ember-test-helpers.
👍 for implementing something that is agnostic. I'm using ember-orbit with ember-mocha and was surprised by describeModel (which wraps moduleForModel) breaking on the ED dependency.
from ember-test-helpers.
We'd happily review a pull request with a proposed solution.
from ember-test-helpers.
Thx @rwjblue, I appreciate your and the rest of contributors' work on this.
I realize I'm not contributing much by simply adding my voice in support of the issue, but the intention is to show that there people who would like this, too.
If I had the means to add a PR for this right now, I would. I'm a long time open source maintainer myself and I realize how much more valuable contributed code is. Having said that, I do believe it is perfectly valid to add to a project by voicing your needs. You, of course, have no obligation to implement what I ask for. I do not feel entitled to anything in regards to the project.
Hey, at least I didn't create a NEW issue without searching existing issues that address my concerns first!
from ember-test-helpers.
I am very sorry if that last comment came off as snarky or negative. I was basically saying that I would definitely be open to a fix, just haven't had time (or a personal need) to dig into it myself yet.
from ember-test-helpers.
All cool. No worries. I was just leaving a little something behind to show that I appreciate the work on this instead of just being a help vampire (can't think of what the OSS equivalent is at the moment).
from ember-test-helpers.
This should be addressed when using the new testing APIs provided by ember-qunit (e.g. moduleForModel is no longer "a thing").
Closing....
from ember-test-helpers.
Related Issues (20)
- Cannot find type definition file for 'ember__test-helpers' after upgrading to v2.9.3 HOT 2
- Regression with `find()` generic type HOT 1
- Rethinking helpers for forms input HOT 2
- Observers not triggered in ember acceptance tests
- [proposal] add hooks support to all dom helpers + settled and wait-until
- Upgrade `registerHook` and `runHooks` as official public APIs HOT 4
- `fillIn` does not work with input values that are decorated with the `readonly` helper HOT 1
- [feature request] pass more information back in error scenarios
- `scrollTo` target type inconsistent with other test helpers
- Setup context fails when using ember-data v4 and a custom resolver
- Allow `waitUntil` to accept a callback that returns a promise HOT 1
- Types missing from version 3 HOT 4
- Anomalies in current published version compared to previous versions HOT 5
- Allow Ember v5
- needed infra maintainence
- 3.2.0 Missing `lookup` and `register` on `Owner` type definition HOT 8
- How to refresh current visiting page in Ember Test?
- Remove old compatibility code
- TypeScript error with `Owner` interface HOT 3
- New app failing to start HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-test-helpers.