GithubHelp home page GithubHelp logo

Comments (7)

rwjblue avatar rwjblue commented on August 16, 2024

@dgeb - We really need to make a game plan for this, as 1.11.0-beta.1 will be shipping in a couple weeks....

from ember-test-helpers.

dgeb avatar dgeb commented on August 16, 2024

@rwjblue ok, so the game plan we discussed in IRC is:

  1. Fix up isolatedContainer to avoid deprecations for now
    1. Build a registry with Application.buildRegistry() - eliminating need for custom registrations
    2. Create a container with registry.container()
    3. Override container.register to call container._registry.register without deprecations. Consider overriding other registry calls without deprecations as well.
  2. If supported, use ApplicationInstance instead of isolatedContainer, in ember-test-helpers

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

Downstream issue in ember-qunit: https://github.com/rwjblue/ember-qunit/issues/118

from ember-test-helpers.

dgeb avatar dgeb commented on August 16, 2024

The deprecation warnings are now showing up in 1.11 beta, so we need to tackle this very soon.

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

Yes, agreed.

from ember-test-helpers.

dgeb avatar dgeb commented on August 16, 2024

See #15 for a quick fix to silence the deprecation warnings. I avoided the steps above (for now) because buildRegistry has gotten more complicated, and now involves configuration of a resolver. I think all that can wait until we straighten out ApplicationInstance and expose that for testing instead of isolatedContainer.

from ember-test-helpers.

Turbo87 avatar Turbo87 commented on August 16, 2024

It seems to me that this issue is no longer relevant 🤔

from ember-test-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.