TypeScript: regular promises not compatible with RSVP? about ember-test-waiters

[scalvert]

After talking to @rwjblue, it sounds like native is fine if you don't support IE11 (makes sense). We should probably use PromiseLike<T>, instead. Just trying to figure out the optimal return type.

[scalvert]

Thanks, @NullVoxPopuli. I could be wrong, but I think the issue here is you're trying to intermix native and RSVP promises.

https://github.com/NullVoxPopuli/emberclear/blob/master/packages/frontend/app/services/toast.ts#L57

You're not importing RSVP promise in this service, but rather using native promises, so waitForPromise will error due to a type mismatch.

[NullVoxPopuli]

waitForPromise will error due to a type mismatch.

right, but waitForPromise is compat with native Promises, so the types should be updated, yeah?

PR: #130

[scalvert]

We specifically import RSVP.Promise and use that in waitForPromise. So I'm not sure that's true?

[scalvert]

We additionally specifically use RSVP.Promise in our tests, so we're not testing for native promises.

[NullVoxPopuli]

sure, but isn't RSVP.Promise pretty much a polyfill at this point? the APIs are the same

[NullVoxPopuli]

like, should I not use waitForPromise / ember-test-waiters if I want to use native promises? seems weird to need to fork the repo for a type error :-\

I s`pose I could add tests for native promises?

[scalvert]

Looking at this again, and playing with it a while, I think we should stick with what you have. If we use PromiseLike<T>, that interface doesn't include catch and finally. That means that we'd be narrowing the return type from waitForPromise, which isn't what we want to be doing.

[scalvert]

Resolved with #130