Comments (18)
@balinterdi I think the plan is to decompose link-to
into a number of helpers & the routing service along the lines of:
This has the added benefit that url-for
& friends can be used outside of the context of rendering a link, eg for passing to components / translation libraries, for more easily setting the active class on container elements etc…
link-to
could still exist and just use those smaller building blocks vs implementing everything itself in a black box.
from rfcs.
component.schedule
and route.schedule
instead of run.schedule
(although mostly this can be achieved without a breaking change, I believe we should deprecate global Ember.run)
from rfcs.
Computed properties without get or set readonly by default?
from rfcs.
@balinterdi My complaints are mostly that the entirety of link-to
should go away. Positional arguments that get turned into content are also really a mess... most of Ember doesn't leverage positional arguments so I want to make that consistent since it's a non-zero logical overhead.
from rfcs.
- Make
get
andset
optional? - Make jQuery optional
- Routable components?
Sounds more like a wishlist.
from rfcs.
import Component from '@ember/component'
please!
from rfcs.
Confirm, these are wishlist items which is why I've not promoted them into the top-post. Y'all please keep this to things that are definitely broken but we can't change without likely breaking peoples applications.
For example, the params thing from my first post: query params clobber path params inside of the params
object passed to the model
hook. Almost certainly somebody relies on this behavior and fixing it requires separating the namespaces. Since that will change semantics and people will need to adjust where they look for properties it is breaking. That params
is lossy is a bug.
This list is for a very specific category of issue.
from rfcs.
Updated the top post to describe what we're looking for in this thread. Please review.
from rfcs.
The function signature for the existing "routing service" is distinct from the function signature of the same method name on the route
and controller
.
The existing routing service: transitionTo(routeName, models, queryParams, shouldReplace)
The underlying implementation on routes: transitionTo(routeName, ...models, options)
I feel like I've opened a bug on the second invocation in the past for unrelated reasons, but can't find it.
We should make these consistent.
from rfcs.
Keep inline link-to
consistent with block format.
vs
The order is backwards and gets me every time I use the inline form. I'd expect:
from rfcs.
Classic actions as {{action "actionName"}}
from rfcs.
@knownasilya I'm personally of the opinion that all of inline {{link-to}}
was a mistake. Also any triple-curly {{{link-to}}}
. Also {{#link-to}}
in general. I'd instead rather deprecate it entirely, but these changes (as well as your proposals) are beyond the scope of this issue.
@Serabe Your proposal also doesn't meet the bar for this thread, it should almost be something that is an unintended side-effect of a feature's implementation.
Both of y'all's proposals have to do with changing documented public API and that would require a deprecation and process. For future travelers if something has ever appeared in the guides there is no way it will be accepted into the top-posted list as that does not count as a bugfix.
from rfcs.
@nathanhammond I agree on deprecating inline {{link-to}}
@Gaurav0 Agree on making computed-properties without a get being readonly
by default, although probably some changes already in the pipeline for computed-properties when decorators can be used will already achieve that.
Deprecate component.sendAction
(perhaps as part of glimmer-components) so people uses closure actions instead.
from rfcs.
As the implementer of the inline link-to
I feel intrigued :) I understand why the param order should be brought in line (pun intended) with the block form, but do you think it should be scrapped? It does save some typing and thus potential messing up, doesn't it?
from rfcs.
@nathanhammond Ok, that makes sense. So what is it going to get replaced by?
from rfcs.
@rlivsey Now this makes perfect sense, thank you for the explanation!
from rfcs.
What about emberjs/ember.js#14783 I'd call that a bug, even though some wouldn't.
from rfcs.
@nathanhammond Can we close this issue? I guess it's not relevant anymore
from rfcs.
Related Issues (20)
- NVP todos
- Deprecate all of Ember Classic HOT 16
- Build-time configuration of index.html HOT 3
- Deprecate support for Travis CI HOT 6
- Deprecate `ember-mocha`? HOT 2
- Deprecate `ember-export-application-global` addon? HOT 4
- Run Prettier separately in `app` blueprint HOT 9
- Deprecate `app.import`
- Thoughts on this more ergonomic way to wire up the owner + destroyable association? HOT 2
- Explore "official" pod deprecation HOT 19
- {{else}} should render a value rather than be a control-flow keyword. HOT 5
- new primitive: transition, similar to modifiers, except they block certain render events HOT 2
- Numbers in PR titles affect automation
- Asset import spec RFC HOT 2
- Implement import spec RFC HOT 1
- Replacing `moduleName` in template meta HOT 11
- Simplified imports for common built-in modules HOT 2
- Pre-RFC: Add `aria-current` attribute to Ember's `LinkTo` component HOT 1
- Whitespace handling for `<template>` tag HOT 4
- Add LICENSE
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rfcs.