Comments (4)
I think maybe fastboot testing should support having
visit()
with afollowRedirects: true
option that can be useful for these scenarios. How does that sound?
Hi @ryanto, thank you for looking into this issue. I wasn't aware of that issue in Fastboot. That was useful to get some context.
The idea of passing followDirects
option to visit sounds like a idea to me, would certainly work for scenarios at LinkedIn. As we return settled DOM after redirection in Fastboot.
We are not blocked on this issue, will be useful. I can work on a PR
from ember-cli-fastboot-testing.
Hey @dnalagatla! Thanks for reporting this.
So I pulled up an old issue from the FastBoot repo about replaceWith
and redirects, and it looks like replaceWith
is designed to respond with a redirect: ember-fastboot/fastboot#54
I think maybe fastboot testing should support having visit()
with a followRedirects: true
option that can be useful for these scenarios. How does that sound?
Also, are you able to work around this issue today or is it blocking you?
from ember-cli-fastboot-testing.
@ryanto I'm hitting this in a production fastboot app... still searching for how to handle it properly
from ember-cli-fastboot-testing.
@erichonkanen it's actually valid scenario that you do not get the DOM of the route to which the initial route redirects using this.replaceWith
, it's by design how FastBoot (and server-side in general) works.
Each url in the web represents unique content hence when you do this.replaceWith
- you redirect user to another page with another url (which by design a separate piece of content).
When app redirects browser to another url, it does so by sending 301/307/308/etc. status code and browsers respect that and navigate to the url retuned in Location
response header.
I guess, in your case you either need to stick to the redirect (and let browser navigate to the new url and get content from it) or you need to switch from using this.replaceWith
to rendering the content you want to render on that url (which means you don't redirect users).
Said above, this does not sound like an issue with this package.
However it may be an enhancement to have something like followRedirects: true
option.
from ember-cli-fastboot-testing.
Related Issues (20)
- Does not work with path=dist HOT 5
- Allow user to access fastboot instance in fastboot-testing.js config HOT 5
- Allow user to pass functions inside the `options` parameter while calling `visit` HOT 1
- Support for ember projects with a rootURL containing a subdirectory HOT 3
- Deprecation Warning in Ember 3.9+ HOT 2
- FastBoot.distPath returns deleted path upon running `ember test` HOT 2
- Allow for custom host in mockServer calls HOT 2
- mockServer.get not working HOT 6
- Error messages are not escaped
- Build fails with latest Babel.js
- A future for this repo. HOT 4
- najax not present when using jQuery in v0.4/v0.5 HOT 1
- Add ability to specify response headers in mocked responses HOT 1
- Use config/fastboot.js instead of separate config/fastboot-testing.js HOT 2
- Config not working HOT 5
- [0.6.0] req.headers.origin undefined in CLI mode
- Skip outputReady in production builds HOT 4
- Cut new release v0.6.1 HOT 4
- Monorepo support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-fastboot-testing.