Comments (1)
LegrandNico
commented on August 20, 2024
Hi @GidLev ,
Thank you for opening this issue and your interest in our package.
The oxi_peaks function is indeed currently a very simple approach to systolic peak detection that has been working very well with the ppg signal we have been analyzing so far (reasonably good quality, only positive values, and sampling rate > 75Hz). So the changes you are proposing make sense for me and would make this function more generalizable to other signals.
You can create a pull request on the dev branch if you want, this function has been renamed ppg_peaks for consistency. I will try to release v0.2.0 later this month.
Thank you for your help with Systole!
from systole.
Related Issues (20)
- plot_evoked does not work as expected for epochs inputs
- Editorial comments to JOSS submission
- Inconsistent spelling of Python
- Package vs library
- Reference not showing up properly HOT 2
- Bibliography
- Recurrence matrix: faster implementation HOT 3
- RR correction order causes index overflows HOT 3
- TypeError: tuple indices must be integers or slices, not str HOT 5
- The Editor's response button is not working
- Add an option to compare corrected and uncorrected peaks in plot_rr
- I want to use this package with emotibit. HOT 2
- Question about function 'readInwaiting' HOT 1
- ppg_peaks draw some error! HOT 2
- Few remarks from a first-timer HOT 3
- bokeh slider is not automatically fitting windows size
- interpolation problem when using ppg_peaks HOT 2
- Labelling of bad segments functionality is not working in the case of artefact rejection for ECG signal
- correct_rr function for ectopic beat correction still produces very high RMSSD a values
- view corrected peaks using systole viewer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from systole.