Comments (6)
@monken
now 1) telemetry execution order has been fixed and 2) requests usage has been replaced by socket, thanks for the suggestions!
from baybe.
Hey @monken
-
Yep, seems like a design flaw in
telemetry
. Possibly simply solved by further shifting where the user and hostname are hashed. Will look into it, doesnt seem urgent from your side -
Was quite tricky to test all cases for this telemetry module because we simply couldn't think about all machine/setup combos let alone have access to them, thanks for the report
-
We need the HTTP request to find out whether the user is within the Merck VPN. If you have a more suitable idea how to test this please let me know (one slight complication was also that the actually telemetry endpoint is not a HTTP but an opentelemetry backend with GRPC protocol if I remember correctly)
-
Didnt know about the rainbow tables, thats tricky indeed, we are shortening the hash which should further increase the amount of possible texts for a given hash, but I guess thats not worth a lot. Any idea how to solve that or use another method for the ideally fully-non-reversible indicator?
from baybe.
You could just do a DNS lookup instead
import socket
socket.gethostbyname('verkehrsnachrichten.merck.de')
Should fail immediately if you are not on the internal network and doesn't require a heavy library like requests
. Would it be possible it have an install target like baybe[notelemetry]
that doesn't ship with this code at all? I really dislike the idea that an import
statement triggers any sort of network request.
- Don't collect user data :)
from baybe.
Hi @monken, thanks for the valuable input. I guess @Scienfitz can have a look into the socket thing and also see how we can further tweak the telemetry part.
Regarding baybe[notelemetry]
: unfortunately, pip has no opt-out mechanism, so we really have no idea how we could handle the problem any better. Let us know if you have a better solution.
Regarding don't collect user data
: @Scienfitz, I guess we could actually drop the hashes entirely? As far as I remember, it was only do disambiguate between devs and non-devs, but we could simply leave the hashes empty for non-devs?
from baybe.
removing the hash would mean we cant track roughly the number of unique users, a main metric we wanted
How much is the technical reversibility of usernames for company-internal users actually a problem?
I would support removing requests but there were additional requirements for this to work on the premade sagemaker kernels on UPTIMIZE AWS which had some sort of issue with it. So Id have to check that again to verify. requests
and opentelemetry*
can already be uninstalled if desired after #194 is merged
from baybe.
the telemetry execution order had beenc hanged to not execute anything when its disabled, this should fix this Issue
will possibly also move towards socket
instead of requests
but will have to test a bit
from baybe.
Related Issues (20)
- Cannot import 'get_canonical_smiles' from 'baybe.utils' HOT 3
- Update baybe/examples/Basics /campaign.py and baybe/examples/Serialization /basic_serialization.py HOT 3
- Handling of Infinity in serialization HOT 7
- ONNX Vulnerabilities HOT 6
- Python 3.12 blocked by failing config checks HOT 3
- Batch_size error HOT 10
- Validation of Campaign object for active_values in TaskParameter in case of string HOT 3
- Installation with Poetry fails with "Package 'baybe[telemetry]' is listed as a dependency of itself." HOT 4
- Expose underlying model of campaign HOT 4
- Recommendations taking a long time HOT 13
- Minor visual issues in the documentation HOT 14
- Simulation bug in `ignore` mode HOT 12
- Error in match mode when trying to take mean of bounds HOT 7
- Return incomplete results when simulation errors out HOT 10
- Random seed being set somewhere hidden inside baybe? HOT 12
- Published docs use main instead of released version HOT 4
- Estimate shape of search space? HOT 5
- ModuleNotFoundError: No module named 'baybe.objectives' HOT 10
- Best way to represent a feature that is a variable-length vector of integers HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baybe.