scale argument about paletteer

[EmilHvitfeldt]

I agree that the scale argument shouldn't be there, its a ugly hack to make the functions work with both strings and symbols. The underlying problem is best described in the following reprex

fun_a <- function(x) {
  x <- rlang::quo_name(rlang::ensym(x))
  x
}

fun_b <- function(x) {
  x <- rlang::quo_name(rlang::ensym(x))
  x <- fun_a(x = x)
  x
}

fun_a("a")
#> [1] "a"
fun_a(a)
#> [1] "a"

fun_b("a")
#> [1] "x"
fun_b(a)
#> [1] "x"

I would want all the 4 call to return "a" but have been unsuccessful so far.

[hadley]

Since fun_b() wraps a function that uses tidy evaluation, it needs to quote and unquote:

fun_a <- function(x) {
  x <- rlang::quo_name(rlang::ensym(x))
  x
}

fun_b <- function(x) {
  x <- rlang::ensym(x)
  x <- fun_a(!!x)
  x
}

fun_a("a")
#> [1] "a"
fun_a(a)
#> [1] "a"

fun_b("a")
#> [1] "a"
fun_b(a)
#> [1] "a"

[EmilHvitfeldt]

ohhh of course! Thank you very much!