Niffler commit workflows are faling. about niffler

[Pavan-Bellam]

@pradeeban , In test_png_extraction.py we have directly called extract_headers function without calling initialize_config_and_execute where we are declaring PublicHeadersOnly and SpecificHeadersOnly as global variables. So we are getting NameError as they have not beet declared. So what I have done is instead of declaring them as global variables I have passed them as arguments to the function.

[Pavan-Bellam]

Hello, I am working on this issue.

[Pavan-Bellam]

Hi @pradeeban, I suppose the issue is with centOS as it has reached its end of life.

[mehulsinha73]

Hi @pradeeban , I have solved this issue, Please check it #288

[pradeeban]

Merged, but CI workflows are still failing, as you can see.

[mehulsinha73]

Yes, I tried to fix it but i haven't familiarized myself with the code base yet. @Pavan-Bellam might be able to help out as the errors are related to #282.

[Pavan-Bellam]

The problem is with container. It might be fixed if we chage it to ubuntu. @pradeeban is it okay to change it?

[Pavan-Bellam]

And this is not related to code. It is related to github actions

[pradeeban]

Yes, you can try and see if that fixes.

[Pavan-Bellam]

Hey @pradeeban , I have submitted a PR regarding this issue. Could you please check it.

[pradeeban]

Hi @Pavan-Bellam, you have changed the file modules/png-extraction/ImageExtractor.py in your pull request. Why is that? This fix must fix only the files in the .workflows directory.

[pradeeban]

Aha, got it. I will need to test this a bit more. I will get back to this by late Monday. Thank you for your contribution.

[Pavan-Bellam]

Okay thank you!

[pradeeban]

Merged.

[pradeeban]

#295 has broken this again. @Nitesh639 can you please have a look?

[pradeeban]

Fixed in dev.

[pradeeban]

Failing again...

[anbhimi]

The test failures are the same as the ones in the previous instance. Here are more details on the test failures

1. One Integration Test Failed (PNG Extraction Module) - The failure did not appear until #323 the following changes in PNG Extraction Module might be the issue at hand.
2. Five Unit Tests Failed (Cold Extraction Module) - These failures were a result of code added to include the StudyMonth attribute.

I will be working on the point 2 test failures.

[anbhimi]

Fixed the Cold Extraction Module Unit Tests at #333

[pradeeban]

Last commits have fixed the commit workflows in dev and main branches.