GithubHelp home page GithubHelp logo

Comments (6)

yandeu avatar yandeu commented on June 9, 2024

It works using webpack. See https://github.com/yandeu/test-enable3d

from enable3d.

brianpeiris avatar brianpeiris commented on June 9, 2024

My guess is webpack assumes a .js extension by default. The three.js issue implies that the esmodule standard is to include the file extension. By omitting it, you will run into issue like this, where the behavior of bundler implementations differ. That said, the behavior around the "exports" section in three.js' package.json file is not standardized, as far as I can tell, so I'm not sure what the correct solution is here.
Do you think I should file a bug against esbuild instead?

from enable3d.

brianpeiris avatar brianpeiris commented on June 9, 2024

Here is node.js' documentation stating that file extensions should be included: https://nodejs.org/api/esm.html#mandatory-file-extensions

from enable3d.

yandeu avatar yandeu commented on June 9, 2024

Has been fixed in 62e00af, ef64981 and fb9ec72.

from enable3d.

brianpeiris avatar brianpeiris commented on June 9, 2024

Great! Thanks. I'll close this now, since this should be resolved with the next release.

from enable3d.

yandeu avatar yandeu commented on June 9, 2024

You're welcome :)

from enable3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.