GithubHelp home page GithubHelp logo

Comments (3)

pvanliefland avatar pvanliefland commented on August 15, 2024

Are you thinking about a solution without SQLAlchemy / Alembic?

from databases.

tomchristie avatar tomchristie commented on August 15, 2024

Kinda. Eg. right now if test cases are using engine.create_all(), engine.drop_all() you're having to use a regular syncronous driver. That's fine but it means that we always have two sets of dependencies. An async database driver for the regular code, and a sync database driver for any migrations or table setup. It'd be nice if we didn't need to do that.

from databases.

tomchristie avatar tomchristie commented on August 15, 2024

Something like...

-    async def execute(self, query: ClauseElement) -> typing.Any:
+    async def execute(
+        self, query: typing.Union[ClauseElement, DDLElement]
+    ) -> typing.Any:
         assert self._connection is not None, "Connection is not acquired"
-        query, args, result_columns = self._compile(query)
-        return await self._connection.fetchval(query, *args)
+        if isinstance(query, DDLElement):
+            compiled = query.compile(dialect=self._dialect).string
+            await self._connection.execute(compiled)
+            return
+        else:
+            query, args, result_columns = self._compile(query)
+            return await self._connection.fetchval(query, *args)

from databases.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.