Comments (4)
alex-oleshkevich
commented on May 28, 2024
1
Feel free to reopen this ticket in case if you still have questions.
from starlette.
alex-oleshkevich
commented on May 28, 2024
@apiwat-chantawibul while I agree that having it in the context is not required anymore, removing request from the context is a breaking change as projects expect this variable to be automatically available in templates.
We can have request as constructor argument of _TemplateResponse and it is an option. However I am not sure if it is a good idea. Many developers are used to have request variable in the template context (so does Django, so do we) and I would prefer to keep this convention further.
What do you think @Kludex ?
from starlette.
Kludex
commented on May 28, 2024
The changes that we propose ourselves on 1.0 solve this issue, right?
from starlette.
alex-oleshkevich
commented on May 28, 2024
Yes, it would be possible to override request context variable in v1.0.
See https://github.com/encode/starlette/pull/2384/files#diff-e36747b146f2f9c644d1ae076c13ee41df4a81132f25f14ebe9c6ad4facb1352L225
from starlette.
Related Issues (20)
- Drop `python-multipart` dependency
- Warn users if setting too large of a session object
- Typing error for app.add_exception_handler (Argument "handler" to "add_exception_handler" of "Starlette" has incompatible type) HOT 1
- TrustedHostMiddleware raises RuntimeError on sending response to websocket HOT 2
- typing map _RequestData in testclient.py might be missing type bytes HOT 2
- Enable `branch = true` for `coverage.run` HOT 4
- Fetching API docs occasionally fails at starlette framework middleware issue with streaming large responses
- links on the release-notes not found. HOT 1
- Add `Partitioned` cookie attribute HOT 2
- `RuntimeError("No response returned")` in `BaseHTTPMiddleware` HOT 3
- Incompatibility with anyio v3
- TestClient DeprecationWarning with httpx 0.27.0 HOT 4
- How to change the value of request body?
- A `RuntimeError: Stream consumed` error is raised when `request.body()` is read in the custom middleware
- CORSMiddleware always add access-control-allow-credentials regardless of Origin
- ValueError when null byte in URL HOT 2
- responses.py - appears UTF incompatible (Line 58 and probably other places)
- Double path unquote inside _TestClientTransport.__init__ method
- [FeatureRequest] Cant configure request.stream() chunk size -- always 128kb per chunk read HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starlette.