GithubHelp home page GithubHelp logo

Comments (5)

kaypee90 avatar kaypee90 commented on June 15, 2024

@Kludex is the idea to use this kind of implementation https://gist.github.com/tomchristie/3293d5b118b5646ce79cc074976744b0 for the WebSocket tests

from uvicorn.

Kludex avatar Kludex commented on June 15, 2024

Yes. Some tweak is needed to use app=app.

from uvicorn.

kaypee90 avatar kaypee90 commented on June 15, 2024

@Kludex app is passed to the config like this

config = Config(
        app=app,
        ws=ws_protocol_cls,
        http=http_protocol_cls,
        lifespan="off",
        port=unused_tcp_port,
    )

Which is then passed to run_server async with run_server(config):
No sure why you need app=app for this

from uvicorn.

likecodingloveproblems avatar likecodingloveproblems commented on June 15, 2024

I have opened a PR for this issue

from uvicorn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.