Comments (4)
Yes, I like it! @sphamil does this sound good to you?
from enrico.
Yes, this looks great!
from enrico.
I also want to consistently refer to the heat/fluids driver as either the "heat", "heat_fluids", or "heatfluids" driver. It's not very consistent right now. For example:
- The element for specifying the driver is
<driver_heatfluids>
(see here) - The value of
<denisty_ic>
is expected to be "heat", not "heatfluids" (see here). Likewise, theInitial
enum has the valueheat
(see here)
I'd like to use "heat" everywhere (not "heatfluids" or "heat_fluids"). It's shorter and you won't have to remember whether to use an underscore or not, which I think is important in writing an input file. Is that okay?
from enrico.
Fixed in #88
from enrico.
Related Issues (20)
- Hiding off-by-one adjustments in NekDriver HOT 2
- Outputting at specified steps? HOT 2
- [Enrico-Nekrs] compile with gcc-9 and gcc-10 HOT 9
- Build failure due to missing sys/sysctl.h HOT 7
- CMake fails for Nek5000 HOT 1
- Write/read heat source to/from Nek fld files HOT 8
- Specify relative tolerance in enrico.xml
- Add check for bulk temperature above saturation
- Compile without OpenMC HOT 1
- Doesn't use external libopenmc.so and instead installs conflicting libopenmc.so HOT 13
- [OpenMC-OpenFOAM] Failed to update temperature after first Picard iteration
- Extend `SurrogateHeatDriver` to support multiple assemblies
- update vendor repo Catch2 to latest release HOT 1
- Disjoint Communicators HOT 1
- Consider combining enrico::CellInstance and openmc::CellInstance
- Opinion about destructor in Comm HOT 4
- Ability to suppress diagnostics HOT 1
- Allow builds without Nek5000 HOT 2
- Error in openmc_driver.cpp HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enrico.