Support parallel server-requests? about yubikey

[enygma]

I hadn't thought about it but I could definitely see it being a useful thing. I haven't looked too much into handling of the connections like this (parallel) but it could definitely be an interesting addition.

It does make use of the Guzzle HTTP client, though, which does make supporting these kinds of parallel connections simpler on the HTTP level. It'd just be a matter of wrapping that handling correctly in the request process. I see in your library you've used the cURL multi handling to make the same kind of thing happen. I think there could be some added benefit to using the Guzzle wrapper for it in terms of determining the "first in" without having to muck with the HTTP level requests manually.

Guzzle Parallel Requests

[enygma]

Additionally, I'd like to move the current hosts list to a default kind of thing and allow for the injection of one or more servers. I could see a host setter with ($hosts, $overwrite = false) to make setting these servers easier. Then add a flag to the constructor (boolean) of whether to use the parallel or single request as it does now.

[enygma]

In looking at what you have in your library so far, it looks like you're still waiting for all of the requests to finish out. You're just using the first one returned as the result. Is this the correct use case you're shooting for here?

[enygma]

Hmm, I think I have something cooperating with a curl multi request but it looks like the API servers don't operate independently. I get an OK on the first few but then start getting a REPLAYED_REQUEST closer to the end of the list. If they're not all evaluating them independently, why even have multi-threaded requests? Please correct me if I'm wrong on this one...

[enygma]

Okay, so if you enable multiple server checking and the "first in" parameter, you can call it like this:

$v = new \Yubikey\Validate($apiKey, $clientId);
$response = $v->check($inputtedKey, true);

echo ($response->success(true) === true) ? 'success!' : 'you failed. aw.';

Note the two new true parameters there. If those are left off or set to false, it will only check one server.

[enygma]

Since this is implemented I'm going to close this one out. If there's any issues, open a new issue with it.