GithubHelp home page GithubHelp logo

Rework inclusion handling about rules_ll HOT 3 CLOSED

eomii avatar eomii commented on June 3, 2024
Rework inclusion handling

from rules_ll.

Comments (3)

neqochan avatar neqochan commented on June 3, 2024

(transitive_)(relative_)(angled_)includes now handle -iquote and -I. We have absolute and workspace-relative includes working, but cross-workspace includes are missing. This is particularly relevant for Projects building on top of LLVM.

We need to be able to reference LLVM and Clang headers from outside the @llvm-project workspace. Since the current implementation uses rules_cc for these targets we need some sort of compatibility layer. Either rules_ll must understand cc_library targets better, or we add ll_* targets to the existing cc_* overlay.

We did not encounter a need for -idirafter, -isystem and -isystem-after, so this is postponed.

from rules_ll.

aaronmondal avatar aaronmondal commented on June 3, 2024

After adding module support we get some unwanted warnings in precompilation steps regarding unused -iquote.... I'm also considering whether we want to change the APIs to have finer-grained control regarding transitivity. Something like

attr
public_attr
transitive_attr

where public_attr is only made available to direct dependencies and transitive_attr is available to all downstream dependencies in the build graph. We need to be careful not to bloat the user interface for ll_library though 😅

from rules_ll.

aaronmondal avatar aaronmondal commented on June 3, 2024

We now removed all transitive_* attributes in favor of exposed_* attributes which don't carry dependencies transitively. I think this is good for now. We can create another issue if this needs another rework.

from rules_ll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.