fetchPokemon does not handle errors correctly about react-suspense

[kentcdodds]

Oh! Nice! I didn't realize that API exists. Would you be interested in making a PR for that?

[kentcdodds]

Hmmm... I thought @cesarcf had addressed this in https://github.com/kentcdodds/react-suspense/pull/37 🤔

[intrueder]

I'm not sure it was a complete fix, because there are two places where the promise is being rejected, but only one was changed from Error to String.
Moreover, ErrorFallback component relies on Error object since it outputs error.message and not just error.

Anyway, this is a different issue, and my previous comment is more about checking the result from the API.
Currently the code checks response.errors, but should check response.data.errors:

      if (response.data.errors) {
        return Promise.reject(
          new Error(response.data.errors.map(e => e.message).join('\n')),
        )
      }

[kentcdodds]

I think I misunderstood the issue @cesarcf was talking about in #37 and that change should be reverted. Doing that now.

[kentcdodds]

@all-contributors please add @intrueder for bugs

[allcontributors]

@kentcdodds

I've put up a pull request to add @intrueder! 🎉

[intrueder]

I just realized, that response.errors is probably there to handle server errors, and if pokemon name is misspelled then error will be handled by else branch, that's why there is no check for response.data.errors
But... what is a server error then? I tried to simulate it by breaking a graphql request (some invalid variable: variables: {namez: name.toLowerCase()}) and the response has no errors field:

At the same time GraphiQL console works in a very different way, I can't see data.errors field in the result:

[kentcdodds]

Keep in mind that we don't actually have a real server in this workshop (so it works offline): https://github.com/kentcdodds/react-suspense/blob/c6a440d3b04b5ba6693423b6c8e65f5fd9c8dbaa/src/backend.js#L32

[intrueder]

Haha 😄 Totally forgot about this. Thanks!
So, here is the problem:
https://github.com/kentcdodds/react-suspense/blob/c6a440d3b04b5ba6693423b6c8e65f5fd9c8dbaa/src/backend.js#L42

I believe it should be:

        ctx.errors([
          {
            message: `Unsupported pokemon: "${req.variables.name}". Try "${randomName}"`,
          },
        ])