Comments (6)
Hi John,
If you could try this changeset or apply it as a patch to test that would be useful, as it does not link into anything I can easier make use of to test it works as expected. That said the change is rather simple, so should just work.
Thanks
David Newman
from eprints3.4.
Hi David,
I don't actually have a 3.4 instance running. I noticed this on our 3.3 instance - but thought (seeing as it's not a bad issue (I'd put it more at a typo level), it wasn't worth fixing in 3.3!
Cheers,
John
from eprints3.4.
I am not aware of any code in 3.3. or 3.4 that integrates with this plugin. If you have some code even for 3.3, that does integrate that you could send me it would allow me to properly test my change.
from eprints3.4.
If you do a 'history search', there's an option to export the result set as a History iCal. I tried using this today (for the first time ever I think), which is when I spotted it...
To validate this fix, run the above, and the resultant iCal file will contain the hostname, rather than .ecs.soton... (unless you're testing on a report with a host of ecs.soton... :o)
from eprints3.4.
NB a visual inspection of your code looks spot-on!
from eprints3.4.
Obviously, history search! I have tested and it looks good.
from eprints3.4.
Related Issues (20)
- Index/Tokenizer problem (RHEL 8, perl 5.26) HOT 6
- Mod-perl handling: HTTP/1.1 404 should be 500 if the document is there and readable but database queries fail
- Add username to Apache request object HOT 3
- Drag 'n' drop issues leading to zero byte files
- "More input rows" button affects layout of Compound field tables in workflow
- Zero byte files from Pure Deposit API HOT 6
- Add 'threads' option to ffmpeg invocations
- Cannot add phrases for alternative languages in Phrase Editor
- Search pages not respecting config template HOT 1
- Internal server error on Subject::Edit screen
- Export plugin to provide downloads URLs for all available documents
- Allow certain URL paths to be blocked for certain IPs HOT 3
- Allow namedset to use vary using function HOT 2
- Manage Deposits slow to load when lots of items HOT 2
- Consider adding template JS var eprints_staff_logged_in HOT 1
- Possible efficiency improvement for Items screen HOT 1
- Incorrect Whitespace in Emails HOT 4
- get_users_owned_eprints breaks eprint_status filters on Items page HOT 5
- Problems with document filenames that look URL encoded HOT 1
- Error if upload files 1MB more HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eprints3.4.