GithubHelp home page GithubHelp logo

Comments (6)

drn05r avatar drn05r commented on August 17, 2024

Hi John,

If you could try this changeset or apply it as a patch to test that would be useful, as it does not link into anything I can easier make use of to test it works as expected. That said the change is rather simple, so should just work.

Thanks

David Newman

from eprints3.4.

jesusbagpuss avatar jesusbagpuss commented on August 17, 2024

Hi David,
I don't actually have a 3.4 instance running. I noticed this on our 3.3 instance - but thought (seeing as it's not a bad issue (I'd put it more at a typo level), it wasn't worth fixing in 3.3!

Cheers,
John

from eprints3.4.

drn05r avatar drn05r commented on August 17, 2024

I am not aware of any code in 3.3. or 3.4 that integrates with this plugin. If you have some code even for 3.3, that does integrate that you could send me it would allow me to properly test my change.

from eprints3.4.

jesusbagpuss avatar jesusbagpuss commented on August 17, 2024

If you do a 'history search', there's an option to export the result set as a History iCal. I tried using this today (for the first time ever I think), which is when I spotted it...

To validate this fix, run the above, and the resultant iCal file will contain the hostname, rather than .ecs.soton... (unless you're testing on a report with a host of ecs.soton... :o)

from eprints3.4.

jesusbagpuss avatar jesusbagpuss commented on August 17, 2024

NB a visual inspection of your code looks spot-on!

from eprints3.4.

drn05r avatar drn05r commented on August 17, 2024

Obviously, history search! I have tested and it looks good.

from eprints3.4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.