ubuntu 19.10: build successful, but no runnable application about acid

[mattparks]

What CXX compiler is being used by CMake? If you run the tests with gdb (build for debug mode) you should be able to get more info for me.

[mattparks]

I made a small change that fixed runtime crashes on Linux: 9305528
If this fixes your issue then close this commit.

[consultit]

I've updated and successfully compiled with both g++ (Ubuntu 9.1.0-9ubuntu2) 9.1.0 and clang version 8.0.1-3 (tags/RELEASE_801/final), but TestGUI, in both cases, issues the following additional message:

File System error adding path or zip (Resources / Engine): not found
Render Stage built in 2.157ms
 [UNASSIGNED-CoreValidation-Shader-OutputNotConsumed] Object: 0x1f (Type = 15) | Vertex attribute at location 2 not consumed by vertex shader
 [UNASSIGNED-CoreValidation-Shader-OutputNotConsumed] Object: 0x25 (Type = 15) | Vertex attribute at location 2 not consumed by vertex shader
 [UNASSIGNED-CoreValidation-Shader-InterfaceTypeMismatch] Object: 0x2b (Type = 15) | Attribute type of `VK_FORMAT_R32_UINT` at location 2 does not match vertex shader input
terminate called after throwing an instance of 'std :: runtime_error'
  what (): Failed to find a valid memory type for buffer
Aborted

[mattparks]

All I can tell is that the exception is thrown from Buffer::FindMemoryType, this is only used when creating Buffers and Images. Some memory property is missing from your device, if you could figure out the calls leading up to the exception using CLion/GDB I could be more helpful.

I don't think I have it written wrong, two memory type resources:

https://github.com/SaschaWillems/Vulkan/blob/4318c6d43e286350dac64487bece3ce5adc624de/base/VulkanDevice.hpp#L126

https://vulkan-tutorial.com/code/29_multisampling.cpp

I've tested master on my AMD R9 390 (Windows, macOS), and NVidia 840M (Linux), and they have no major issues.

[consultit]

After some debug sessions of TestGUI I found that Buffer::FindMemoryType() is called several times with the following different combinations of the (typeFilter, requiredProperties) parameters, that I report:

(160, 1)
(130,  1)
(1665, 6)
(1665, 1)
(1665, 4)
(1665, 3) -> throws exception

the last combination throws the exception.
I'm definitely not a vulkan expert, so I don't know how to make it work with my video card.
P.S. this is the stack trace:

Thread #1 [TestGUI] 2366 [core: 0] (Suspended : Signal : SIGABRT:Aborted)	
	__GI_raise() at raise.c:50 0x7ffff700bbfb	
	__GI_abort() at abort.c:79 0x7ffff6fec855	
	0x7ffff73be5fa	
	0x7ffff73ca9bc	
	std::terminate() at 0x7ffff73caa17	
	__cxa_throw() at 0x7ffff73cac79	
	acid::Buffer::FindMemoryType() at Buffer.cpp:98 0x7ffff7d3e1c4	
	acid::Buffer::Buffer() at Buffer.cpp:35 0x7ffff7d3dd2f	
	std::make_unique<acid::Buffer, unsigned long const&, int, int>() at unique_ptr.h:853 0x7ffff7ca403c	
	acid::Model::SetIndices() at Model.cpp:85 0x7ffff7ca3a70	
	acid::Model::Initialize<acid::VertexDefault>() at Model.inl:63 0x7ffff7bdb157	
	acid::ModelRectangle::Load() at ModelRectangle.cpp:75 0x7ffff7cd3fab	
	acid::ModelRectangle::Create() at ModelRectangle.cpp:20 0x7ffff7cd34ab	
	acid::ModelRectangle::Create() at ModelRectangle.cpp:29 0x7ffff7cd35e0	
	acid::Gui::Gui() at Gui.cpp:11 0x7ffff7be5ebd	
	acid::UiStartLogo::UiStartLogo() at UiStartLogo.cpp:19 0x7ffff7e16fdb	
	test::Scene1::Scene1() at Scene1.cpp:16 0x5555555be4cc	
	std::make_unique<test::Scene1>() at unique_ptr.h:853 0x5555555ab841	
	test::MainGame::MainGame() at MainGame.cpp:95 0x5555555a51ac	
	std::make_unique<test::MainGame>() at unique_ptr.h:853 0x5555555aadb0	
	main() at MainGame.cpp:19 0x5555555a4356	

[mattparks]

I'm fairly sure this is caused from models, specifically: https://github.com/EQMG/Acid/blob/3d4494e5ec07844a479545c2bf2c5c1776feeec3/Sources/Models/Model.cpp#L86 The last parameter should look like this: https://github.com/EQMG/Acid/blob/3d4494e5ec07844a479545c2bf2c5c1776feeec3/Sources/Models/Model.inl#L47 I don't think it was intentional to have the indices buffer builder buffer access different from the vertices. I can test these changes on my machines tonight. Sorry that finding what's wrong has taken so long.

…

On Fri, 16 Aug 2019, 14:07 consultit, ***@***.***> wrote: After some debug sessions of TestGUI I found that Buffer::FindMemoryType() is called several times with the following different combinations of the (typeFilter, requiredProperties) parameters, that I report: (160, 1) (130, 1) (1665, 6) (1665, 1) (1665, 4) (1665, 3) -> throws exception the last combination throws the exception. I'm definitely not a vulkan expert, so I don't know how to make it work with my video card. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#75?email_source=notifications&email_token=AA6VNYPJ5I676VC7DBNAK2TQE33IVA5CNFSM4ILVBZJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4POP5Y#issuecomment-522119159>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6VNYLC42LH4YFHEACQLCTQE33IVANCNFSM4ILVBZJA> .

[consultit]

Just updated the source and TestGUI seems to work.