GithubHelp home page GithubHelp logo

Comments (5)

jbelien avatar jbelien commented on May 26, 2024

That will be automatically fixed in every website at next (automated) deployment.

from equalstreetnames.

jbelien avatar jbelien commented on May 26, 2024

This is still not fixed...

There is definitely a conflict between bounds (or fitBounds()) and the parameters from the hash (https://github.com/maplibre/maplibre-gl-js/blob/main/src/ui/map.js#L447-L462)

from equalstreetnames.

jbelien avatar jbelien commented on May 26, 2024

The issue is fixed when using app.center + app.zoom.

if (typeof center !== 'undefined' && typeof zoom !== 'undefined') {
options.center = center;
options.zoom = zoom;
}


The issue is not fixed when using app.bbox.
The issue is not fixed when app.center, app.zoom, and app.bbox are not defined (the app uses bounds from boundary.geojson in that case).
Reason: https://github.com/maplibre/maplibre-gl-js/blob/main/src/ui/map.js#L458-L461


Mapbox geo-viewport (converting bounds to zoom level + center) seemed to be a solution but won't work since we need the map size which is only available after page load.

from equalstreetnames.

jbelien avatar jbelien commented on May 26, 2024

Well ... That IS fun(ny) ...

I commited 8a92b0c for consistency with previous commit and ... it seemed to have fixed this issue.

I've deployed the update on https://equalstreetnames.brussels/ and it seems to works as expected.
I'll wait for deployment on all websites to close this issue.

from equalstreetnames.

jbelien avatar jbelien commented on May 26, 2024

It seems to be fixed ! πŸŽ‰

from equalstreetnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.