New city (Leiden, Netherlands) - PHP error? about equalstreetnames

[RobinLinde]

Started mapping as well...

[RMHogervorst]

You're right! Macos ships a very old version of php! I'll try again with a new version 'brew install php'

[jbelien]

My guess concerning the DivisionByZeroError was indeed that there was no data to process.
I'll add an error and stop the process if it happens so we don't get the DivisionByZeroError.

[RMHogervorst]

awesome! Yes I was going to open an issue for that, but it works just as well in this one!

[jbelien]

I'll make the process updates later today (or tomorrow):

• Add submodule
• Enable automated data process
• Enable automated website deployment
• Add city to README
• Add city to global website (https://equalstreetnames.be/)

[RMHogervorst]

✅ done

[jbelien]

Hello @RMHogervorst ,

First things first: welcome on board!

You're indeed right, I used Typed Properties that appears in PHP 7.4 but still accept PHP 7.2 and PHP 7.3 in composer.json.
I'll update the composer.json file.

You're probably using a version of PHP prior to PHP 7.4.
Please upgrade to PHP 7.4 or PHP 8.0 !

[RMHogervorst]

oh god, you have to force macos to use a newer version.
If anyone has the same issue: use brew to install a new version of php brew install php
This will tell you where that version is installed.
Add that path to the PATH. So in your .bash_profile (or zsh config)
Add a line like this: export PATH=/usr/local/Cellar/php/8.0.5/bin:$PATH this will put the php version of homebrew before the standard macos version. Check if you have new version by first restarting the shell, or running the export PATH line I just mentioned. and call which php in your terminal to see if you have recent version. In my case it should read /usr/local/Cellar/php/8.0.5/bin/php

[RMHogervorst]

unfortunately this is not enough, I have a new error! I think I'm not getting the correct data.
I get a Uncaught DivisionByZeroError: Division by zero in PATHTOTHERIGHTFOLDER/equalstreetnames/process/Command/StatisticsCommand.php:123 So I guess it isn't downloading the right values?

The gender.csv and the other files are all without data (do contain headers). the boundary.geojson is filled though.

            $output->writeln([
                sprintf('Person: %d', $total),
                sprintf('  Female (cis): %d (%.2f %%)', $genders['F'], $genders['F'] / $total * 100),
                sprintf('  Male (cis): %d (%.2f %%)', $genders['M'], $genders['M'] / $total * 100),
                sprintf('  Female (trans): %d (%.2f %%)', $genders['FX'], $genders['FX'] / $total * 100),
                sprintf('  Male (trans): %d (%.2f %%)', $genders['MX'], $genders['MX'] / $total * 100),
                sprintf('  Intersex: %d (%.2f %%)', $genders['X'], $genders['X'] / $total * 100),
                sprintf('  Non-Binary: %d (%.2f %%)', $genders['NB'], $genders['NB'] / $total * 100),
                sprintf('  Multiple: %d (%.2f %%)', $genders['+'], $genders['+'] / $total * 100),
                sprintf('  Unknown: %d (%.2f %%)', $genders['?'], $genders['?'] / $total * 100),
                sprintf('Not a person: %d', $genders['-']),
            ]);

[RMHogervorst]

hmm it doesn't download the right roads

> php process.php geojson '--city=netherlands/leiden'
Generate GeoJSON files.
City: netherlands/leiden
Relations: 0 node(s), 0 way(s), 0 relation(s)
    0 [->--------------------------]
Ways: 0 node(s), 0 way(s), 0 relation(s)
    0 [->--------------------------]

[RMHogervorst]

I first used the wrong OSM relation, (there are 2 for leiden) and so the boundary and adminlevel did not match. It took several tries but now I have a better relation with corresponding adminlevel and it downloads streets!

[RMHogervorst]

Thanks for all the help! it seems to work really well now!

[jbelien]

My pleasure. 😃

I've created a @EqualStreetNames/leiden team. in case you want to merge Leiden with the rest of the cities by transferring your repository under @EqualStreetNames organization. You'll of course stay admin of the repository if you decide to transfer it (see https://github.com/EqualStreetNames/equalstreetnames-template#integrate-your-city-to-the-project)

[jbelien]

@RMHogervorst Could you already create a MAPBOX_TOKEN secret variable with your (valid) Mapbox token in your repository : https://github.com/EqualStreetNames/equalstreetnames-leiden/settings/secrets/actions/new ?

[jbelien]

Website is live: https://leiden.equalstreetnames.eu/en/index.html 🚀

---

Domain name leiden.equalstreetnames.eu is "offered" and managed by @RobinLinde.
Let us know if you want to setup your own domain name.

[jbelien]

I think everything is up and running so I'll close this issue.