GithubHelp home page GithubHelp logo

Comments (17)

RobinLinde avatar RobinLinde commented on May 27, 2024 2

firefox_HvpqdzEBkP

I've now got a basic 'editor' that takes an OSM way or relation, gets associated tags and tries to provide a suggestion for a Wikidata entry. Now it just needs to add the info to OSM...

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024 2

Later today has arrived πŸ˜‰, I published it over at RobinLinde/ESN-edit. Still needs the same updates though 😐.

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024 1

To be honest I have been thinking of building a dedicated editor, and have some ideas about how that should function.
Somethin simple like a list of streets, a detail page where you select a wikidata entry and just go to the next one.
The hardest thing is finding the time to do it...

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024 1

firefox_YwJyZm7mr5

d7d6e9d implements a basic version without any regards for element type (or code quality).

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024 1

Link will appear automatically after next update for each city ! πŸš€

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

Hello @nitramwin ,

That's indeed an excellent idea and would be helpful for the project but it's (currently) out of the scope of the project.

That being said, any help to make it happen is more than welcome.

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

I like it but I would try to keep it a bit more "hidden", a regular user is probably not interested by that function.
Also see d7d6e9d#r50417173

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024

firefox_E6SBWpgfVhfirefox_iZxHFLWKY0

Able to make changesets now as well, just need to sort out some more error handling and quite a few usability improvements.

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

Nice ! Well done @RobinLinde ! πŸ‘

I would also maybe add a #equalstreetnames hashtag to the changeset comment so we can easily check the changesets if needed.

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024

Rewrote the complete changeset code today, also includes #equalstreetnames in the commment (https://master.apis.dev.openstreetmap.org/changeset/215178). Will publish the code probably later today, have been having some trouble to get it to build properly earlier. Still haven't improved usability that much. Right now the only feedback on whether an edit succeeded is some vague message in the console.

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

Looking good, let us know when you're looking for feedback ! :)

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024

Just made the first changeset on production server: https://www.openstreetmap.org/changeset/104702072. The version on edit.equalstreetnames.eu should be working enough to do some edits.

There is still a lot of room for improvement, for example the list of common words it filters isn't that complete. It would probably be a good idea to allow the user to alter the search term, as well as the search language, which currently defaults to English.

As always, any feedback, comments or other remarks is very welcome.

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

Awesome work @RobinLinde ! πŸ‘

I suggest we close this issue here and use issues on your repository (https://github.com/RobinLinde/ESN-edit/issues).

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024

Might be worth to keep this open, while I do now have a basic editor, there is no proper implementation of a link yet...
Any other issues or problems can indeed be raised there (https://github.com/RobinLinde/ESN-edit), I've also enabled discussions there, seems like a good idea.

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

[...] there is no proper implementation of a link yet...

Fair point!

from equalstreetnames.

RobinLinde avatar RobinLinde commented on May 27, 2024

popup
popup

I have a new, more subtle version of an edit link, that still needs some refinement over in #200.

from equalstreetnames.

jbelien avatar jbelien commented on May 27, 2024

Nice, I was indeed thinking something like that. πŸ‘

from equalstreetnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.