Comments (10)
@eivindjahren are the tests above part of a branch about to be merged - or should I add similar tests to this PR?
from ert.
@frode-aarstad You can just uncomment the lines marked with issue 7046 here:
ert/tests/unit_tests/storage/test_local_storage.py
Lines 385 to 389 in 4743427
from ert.
The issue here is if we should allow construction of SummaryConfig
with no keys. When reading summary and this is the case we throw an exception.
from ert.
The issue here is if we should allow construction of
SummaryConfig
with no keys. When reading summary and this is the case we throw an exception.
Can the bug be triggered by putting SUMMARY ""
in the config file?
from ert.
It might be that all we need is to update the documentation of RealizationStorageState
. I'll have a check.
from ert.
Storage is quite inconsistent with what it considers "HAS_DATA". Usually, a forall quantifier in front of an empty collection is considered True (see https://en.wikipedia.org/wiki/Vacuous_truth). That is why all([]) == True
.
However, when LocalEnsemble.response_configuration
is empty, _all_responses_exist_for_realization
returns False
, but if LocalEnsemble.response_configuration
contains an SummaryConfig
without keys, you get True
.
This is also inconsistent with _get_parameter_mask
which uses
all(
path / f"{parameter}.nc").exists()
for parameter in self.experiment.parameter_configuration
)
from ert.
I suggest we do the following: #7150 which enforces that SummaryConfig must have keys and changes the name and documentation of the existence checks in local_ensemble.
Also, I think the comment in _filter_response_configuration
is incorrect as it dis produce a file, but that file actually ended up the triggering the bug #6974 so now that is a forward model failure. So now that SummaryConfig cannot have empty keys, I removed _filter_response_configuration
as it does nothing.
from ert.
I think the proposed solution of forcing SummaryConfig to have keys is good and leads to the proposed simplifications to local_ensemble
from ert.
After looking a bit closer at it, that solution seems to not be possible as it would break with current behavior that
summary keys from HISTORY_OBSERVATION
are added to the summary config if missing.
ert/src/ert/config/observations.py
Lines 110 to 111 in 1ff65a5
from ert.
It seems like this issue is less problematic than first anticipated so we can lower the severity of the bug at least.
from ert.
Related Issues (20)
- Presumably finished realization displayed as pending in joblist view HOT 3
- Success or failure of realization is logged with debug log level HOT 2
- Jobs not submitted to lsf HOT 1
- Validate that MAX_SUBMIT is larger than 0
- Provide correct realization state when resubmitting the forward model HOT 2
- Clicking observations in Experiment manager crashes ert HOT 1
- Drivers should pick NUM_CPU from the Realization class HOT 1
- Deprecate NUM_NODES and NUM_CPUS_PER_NODE in OpenPBS driver HOT 1
- Acquiring LSF jobid is flaky when submitting the job HOT 2
- Task running the job was not killed properly
- Investigate frequent bjobs failure HOT 2
- Python LSF driver does not pick the correct NUM_CPU
- Terminating jobs fails using jobqueue HOT 3
- Wrong state of realizations in Scheduler after terminate experiment
- Variable naming: *_name or *_key? HOT 1
- Verify that the selected queue type can be used HOT 1
- Ert not able to run csh jobs in test_run
- `test_monitor.py::test_unexpected_close` is flaky
- Checking if responses exist for realization is very slow
- "Parameter/response states" view incorrect for realization in Manage Experiment views
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ert.