GithubHelp home page GithubHelp logo

Comments (1)

olwijn avatar olwijn commented on June 30, 2024

The usage of "Eclipse" in the code is mostly restricted to functionality to read from ECLIPSE-formatted simulation output (at this moment actually ECLIPSE simulations). In most other cases it appears in comments in combinations such as "Eclipse/Flow", or clearly refers to a required formatting that follows the 'Eclipse conventions'. In my view such usages are appropriate.

I think replacement of "eclipse" by "flow" is warranted for example in the name of the file location where simulation results appear, since these will be obtained by running Flow. The following code lines were identified where changes shold perhaps be made:

src/flownet/config_parser/_config_parser.py 32
src/flownet/config_parser/_config_parser.py 417
src/flownet/config_parser/_config_parser_pred.py 82
src/flownet/network_model/_generate_connections.py 317, 440, 448 (comment)
src/flownet/realization/_render_realization.py 20 (comment)
src/flownet/templates/common_config.ert.jinja2 29, 31-34

from flownet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.