Gracefully fail instead of `Killed` about libres

[pgdr]

Just a quick question: shouldn't all these

if (job->active)
  do_a();
else
  do_b();

be contained within mutex_lock?

What about adding something like this?

diff --git a/libjob_queue/src/local_driver.c b/libjob_queue/src/local_driver.c
index 19d2471..bcc8261 100644
--- a/libjob_queue/src/local_driver.c
+++ b/libjob_queue/src/local_driver.c
@@ -30,6 +30,7 @@
 #include <ert/job_queue/queue_driver.h>
 #include <ert/job_queue/local_driver.h>
 
+#include <ert/res_util/res_log.h>
 
 typedef struct local_job_struct local_job_type;
 
@@ -70,10 +71,19 @@ static local_job_type * local_job_alloc() {
 }
 
 static void local_job_free(local_job_type * job) {
-   if (job->active)
-      job->free_when_finished = true;
-   else
-      free(job);
+  res_log_add_message_str(LOG_INFO,
+                          "Local queue driver asked to free job ...");
+  pthread_mutex_lock( &driver->submit_lock );
+  if (job->active) {
+    res_log_add_message_str(LOG_INFO,
+                            "job is active, will free when finished");
+    job->free_when_finished = true;
+  } else {
+    res_log_add_message_str(LOG_INFO,
+                            "job is not active, freeing.");
+    free(job);
+  }
+  pthread_mutex_unlock( &driver->submit_lock );
 }

[joakim-hove]

shouldn't all these [...] be contained within mutex_lock?

I think it correct to do this unlocked; the locking should happen at the queue level - i.e. higher up; but I will take a hard look, you might be right!

[joakim-hove]

Is looked at a higher level: https://github.com/Statoil/libres/blob/master/libjob_queue/src/job_node.c#L594