`make test` error: "./system_test.sh: 19: Syntax error: "}" unexpected" about entr

[infokiller]

Just to clarify, this happens on master (commit 944eb59) but not on the latest release 5.2.

[eradman]

I partially addressed this in commit 7cbfb78

Run system tests using bash if /bin/sh does not have ksh features

The real change is that the old unit tests no longer exist, so make test runs the system tests which are much more rigorous. This will add a lot of dependencies to your docker image, so you probably don't want to run this as part of your build.

[infokiller]

Thanks, that fixes the original issue with the curly braces. Are there any other dependencies that are missing to run the system tests like above, other than vim and tmux?

I tried the commands below, but it fails:

build_oci_img() {
  docker build "$@" - <<EOF
  FROM debian:10
  RUN DEBIAN_FRONTEND=noninteractive apt-get \
      -o DPkg::options::="--force-confdef" \
      -o DPkg::options::="--force-confold" \
      update -y && \
    DEBIAN_FRONTEND=noninteractive apt-get \
        -o DPkg::options::="--force-confdef" \
        -o DPkg::options::="--force-confold" \
        install --no-install-recommends -y \
        make git ca-certificates gcc build-essential vim tmux
  RUN git clone https://github.com/eradman/entr/
  WORKDIR entr
  RUN ./configure && make test
EOF
}

build_oci_img

docker run --rm --interactive --tty "$(build_oci_img -q)"

I get:

...
Step 5/5 : RUN ./configure && make test
 ---> Running in 6e0e1345e194
cp Makefile.linux Makefile
cc  -D_GNU_SOURCE -D_LINUX_PORT -Imissing -DRELEASE=\"5.3\"  missing/strlcpy.c missing/kqueue_inotify.c entr.c -o entr
./system_test.sh
........
FAIL: exec a command using one-shot option
'1' != '0'
make: *** [Makefile.bsd:9: test] Error 1
The command '/bin/sh -c ./configure && make test' returned a non-zero code: 2

[eradman]

It doesn't look like you're missing any dependencies.

Do the tests complete outside of Docker?

[infokiller]

No, I get this error:

./system_test.sh
.....can't find window: 0
.can't find window: 0
.can't find window: 0

FAIL: spacebar triggers utility
'waiting' != 'finished'
make: *** [Makefile.bsd:9: test] Error 1

[eradman]

I couldn't reproduce this failure on an Ubuntu 11 VM. @infokiller are you running on amd64 or another platform?

[infokiller]

Yes, amd64. Do you mean Debian 11?
Does that reproduce with docker?
Using docker is likely more reliable/reproducible than a VM with an arbitrary image, so it's better to use it

[infokiller]

Also, I use Archlinux as the host system

[infokiller]

To improve reproducibility, I also pinned the image digest and commit hash so that we you the exact same one. It's still not 100% reproducible because (the packages fetched are not pinned), but it's highly unlikely you won't be able to reproduce it this way:

build_oci_img() {
  docker build "$@" - <<EOF
  FROM debian@sha256:f21a32253b030826c59cd71de36996e2fd6d820d47f40a6fc1b30d64db677837
  RUN DEBIAN_FRONTEND=noninteractive apt-get \
      -o DPkg::options::="--force-confdef" \
      -o DPkg::options::="--force-confold" \
      update -y && \
    DEBIAN_FRONTEND=noninteractive apt-get \
        -o DPkg::options::="--force-confdef" \
        -o DPkg::options::="--force-confold" \
        install --no-install-recommends -y \
        make git ca-certificates gcc build-essential vim tmux
  RUN git clone https://github.com/eradman/entr
  WORKDIR entr
  RUN git checkout -q 7cbfb78 && ./configure && make test
EOF
}

build_oci_img

docker run --rm --interactive --tty "$(build_oci_img -q)"

Output:

./system_test.sh
........
FAIL: exec a command using one-shot option
'1' != '0'
make: *** [Makefile.bsd:9: test] Error 1
The command '/bin/sh -c ./configure && make test' returned a non-zero code: 2

[eradman]

Do you mean Debian 11?

Yes Debian 11

The Docker image revealed some missing dependencies: also install the procps and file packages (I'll add a check for the pgrep and file commands)

We need another line to configure git in the image

git config --global user.email "[email protected]"

The rest of the failures appear in docker build, but not docker run:

alpine:~$ docker run --rm --interactive --tty 90c01cbe20e0
root@e9ae70c0b907:/entr# ./system_test.sh
..................s...................................................................
42 tests PASSED

[infokiller]

Thanks, confirmed this works. For reference, here's the full script for testing:

build_oci_img() {
  docker build "$@" - <<EOF
  FROM debian@sha256:f21a32253b030826c59cd71de36996e2fd6d820d47f40a6fc1b30d64db677837
  RUN DEBIAN_FRONTEND=noninteractive apt-get \
      -o DPkg::options::="--force-confdef" \
      -o DPkg::options::="--force-confold" \
      update -y && \
    DEBIAN_FRONTEND=noninteractive apt-get \
        -o DPkg::options::="--force-confdef" \
        -o DPkg::options::="--force-confold" \
        install --no-install-recommends -y \
        make git ca-certificates gcc build-essential vim tmux file procps
  RUN git config --global user.email "[email protected]"
  RUN git clone https://github.com/eradman/entr
  WORKDIR entr
  RUN git checkout -q 7cbfb78
EOF
}

build_oci_img

docker run --rm --interactive --tty "$(build_oci_img -q)" bash -c './configure && make test'

[eradman]

Thanks @infokiller. Added the extra requirements in commit 8b00bce