GithubHelp home page GithubHelp logo

euf_nutshell_kit's People

Contributors

denniserdmann avatar richardhj avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

euf_nutshell_kit's Issues

Setup an individual folder name needs to rebuild symlinks

When using the installer, i choose a the folder name theme . After installation finished i was wondering why i can choose a css file in the backend but get an error when trying to load the css in the frontend.

Turns out there was a symlink to the default folder name starterkit

  • Before symlinking: web/files/starterkit
  • After symlinking: web/files/theme

Maybe we should add this to the readme file or put it into the nutshell installer.

Update dependencies

Hello,

meanwhile, the declared dependencies are fairly outdated. I tried to upgrade all packages – especially Gulp and it worked quite smoothly. Rewriting the gulpfile.js to leverage the new Gulp.js 4 syntax was straighforward as well. If you wish, I could provide a PR :-)

Cheers

Hard dependency of Conato core 4.4.* prevents composer update to Contao 4.9.*

Line 14 of composer.json lists:
"contao/manager-bundle": "4.4.*",

This causes update installations from Contato 4.4.x to the current LTS version 4.9 to fail. There should not be significant compatibility issues between 4.4 and 4.9, so I would therefore suggest to simply change that single line to
"contao/manager-bundle": "^4.4",
and check if that works.

Rename deploy task to build

Hello,

I think the naming of the main gulp tasks is a little off, because the deploy task is actually not deploying anything but building the theme for deployment. Hence I propose to rename deploy to build :-)

Cheerio

Contao 4: gulpfile.js und package.json liegen unter /files

Das Composer Plugin bietet unter Contao 4 nicht mehr die Möglichkeit, Dateien im root anzulegen, sondern lediglich unter root/files. Dadurch können auch gulpfile.js und package.json nicht wie unter Contao 3.5 automatisch im root angelegt werden.

Hier sehe ich aktuell nur 2 Möglichkeiten:

  1. README anpassen: Hinweis geben, dass die beiden Dateien zukünftig aus /files in root verschoben werden sollen
  2. dauerhaft in /files arbeiten, was neue Probleme in Bezug auf den Ordner templates mit sich bringt. Auch würdr node_modules dann unter files liegen und erstmal von Contao indexiert werden

Gibt es hier noch andere Ideen/Vorschläge?

Composer plugin + require-dev

I want to propose two things:

  1. Create a composer-plugin, so we don't need to define the scripts in the compose.json anymore. erdmannfreunde/euf_nutshell_installer#1
  2. Move the dependency of the installer from require to require-dev. We don't need the installer on production systems.

Tasks

  • Merge erdmannfreunde/euf_nutshell_installer#1
  • Release euf_nutshell_installer v0.2.0
  • Add require-dev ErdmannFreunde/euf_nutshell_installer:^0.2 in this repository
  • Remove the require of ErdmannFreunde/euf_nutshell_installer:dev-master
  • Remove the two lines in the "scripts" section of the composer.json

In case you want to test the changes

You can test the new version of the installer with this composer.json:

{
    "name": "erdmannfreunde/euf_nutshell_kit",
    "description": "Start a new contao project based on the nutshell framework",
    "type": "project",
    "license": "GPL-3.0-or-later",
    "authors": [
        {
            "name": "Dennis Erdmann",
            "email": "[email protected]"
        }
    ],
    "require": {
        "php": "^5.6|^7.0",
        "contao/manager-bundle": "4.4.*",
        "contao/calendar-bundle": "^4.4",
        "contao/comments-bundle": "^4.4",
        "contao/faq-bundle": "^4.4",
        "contao/listing-bundle": "^4.4",
        "contao/news-bundle": "^4.4",
        "contao/newsletter-bundle": "^4.4",
        "erdmannfreunde/euf_nutshell": "^0.4",
        "roave/security-advisories": "dev-master"
    },
    "require-dev": {
        "erdmannfreunde/euf_nutshell_installer": "dev-feature/composer-plugin"
    },
    "repositories": [
        {
            "type": "git",
            "url": "[email protected]:richardhj/euf_nutshell_installer.git"
        }
    ],
    "config": {
        "component-dir": "assets"
    },
    "scripts": {
        "post-install-cmd": [
            "Contao\\ManagerBundle\\Composer\\ScriptHandler::initializeApplication"
        ],
        "post-update-cmd": [
            "Contao\\ManagerBundle\\Composer\\ScriptHandler::initializeApplication"
        ]
    }
}

contao-component-dir

Hallo,
sollte es in der composer.json nicht den Bereich
"extra": { "contao-component-dir": "assets" },
geben?
Statt dessen wird das veraltete
"config": { "component-dir": "assets" }, verwendet! Das hat bei mir mit 4.9.10 manchmal zu Problemen im Manager geführt. Seit ich die composer.json in meinem Projekt geändert habe läuft alles wie geschmiert.

Composer-Fehler

Ich wollte eben euer framework mal in ner Contao 3.5.26 Installation ausprobieren. Dazu habe ich:
php composer.phar require erdmannfreunde/euf_nutshell_kit eingegeben.

Dann gab er mir folgendes als Fehler zurück:


`Your requirements could not be resolved to an installable set of packages.

Problem 1
- Installation request for erdmannfreunde/euf_nutshell_kit ^0.2.0 -> satisfiable by erdmannfreunde/euf_nutshell_kit[0.2.0].
- erdmannfreunde/euf_nutshell_kit 0.2.0 requires contao/core-bundle >=3.5,<=3.5.9999 -> no matching package found.

Potential causes:

Read https://getcomposer.org/doc/articles/troubleshooting.md for further common problems.

Installation failed, reverting ./composer.json to its original content.`


So wie ich das verstehe, referenziert das Modul auf contao/core-bundle. Das aber evtl. für die alte 3.5.x Version so nicht heißt. Denn wenn ich mir die Contao- composer.json anschaue, dann heißt diese contao/core und nicht contao/core-bundle

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.