Placeholders don't work with express 4 about grunt-express-server

[ericclemmons]

I'm... confused?

[dhaub]

I was working on an express 4 application and my bases were not being
inserted where I had put the "staticPlaceholders" function in the
processing pipeline ("stack"). They were defaulting to the end of the
pipeline, which is what it does when there are no placeholders. I debugged
the application and found that references to "server.stack" in lib/util.js
were always empty. I guessed that express had moved the pipeline. I found
it in server._router.stack.

Modifying the code to look for the stack in this new location fixed the
problem. I've send you a pull request with my suggested fix.

Unfortunately, the tests don't seem to work on my machine, so I was unable
to add any new tests to test this functionality, other than it works with
my express application. I'm using express version 4.4.3

Thanks for writing this module. It's been extremely helpful.

On Fri, Jun 20, 2014 at 5:01 PM, Eric Clemmons [email protected]
wrote:

I'm... confused?

—
Reply to this email directly or view it on GitHub
#62 (comment)
.

[dhaub]

Sorry, Eric, I posted this issue to the wrong project - it was for
grunt-express not grunt-express-server.

On Fri, Jun 20, 2014 at 5:16 PM, David Haubenstricker [email protected]
wrote:

I was working on an express 4 application and my bases were not being
inserted where I had put the "staticPlaceholders" function in the
processing pipeline ("stack"). They were defaulting to the end of the
pipeline, which is what it does when there are no placeholders. I debugged
the application and found that references to "server.stack" in lib/util.js
were always empty. I guessed that express had moved the pipeline. I found
it in server._router.stack.

Modifying the code to look for the stack in this new location fixed the
problem. I've send you a pull request with my suggested fix.

Unfortunately, the tests don't seem to work on my machine, so I was unable
to add any new tests to test this functionality, other than it works with
my express application. I'm using express version 4.4.3

Thanks for writing this module. It's been extremely helpful.

On Fri, Jun 20, 2014 at 5:01 PM, Eric Clemmons [email protected]
wrote:

I'm... confused?

—
Reply to this email directly or view it on GitHub
#62 (comment)
.