group not alphabetically about nxviz

[ericmjl]

@noragak thanks for pinging in! Let me check the source code to see where this is happening.

[ericmjl]

I see it's happening here.

I see where you're coming from - the intent is to allow an end-user to specify the order of the groups rather than automatically do so.

What do you think the API design should look like to enable this?

[norakassner]

Difficult question!

1. So one option would be again another parameter like "grouping_order" where one can choose between "alphabetically" and something like "default" (like a first come first serve order of the node annotations which later build the groups). Also maybe different parameters. But that are the only ones I can think of right now...
2. But maybe there is an easier way?

[ericmjl]

So one option would be again another parameter like "grouping_order" where one can choose between "alphabetically" and something like "default" (like a first come first serve order of the node annotations which later build the groups). Also maybe different parameters. But that are the only ones I can think of right now...

I think this is a great idea! Just have to make sure that grouping_order is right next to node_grouping in the docstrings, of course, otherwise it'll be easy to miss that one. 😄.

[norakassner]

Great. I'll start implementing it today. What other options should be added other than "alphabetically", "default"?

[ericmjl]

Thanks @noragak! I think those look good for now. Perhaps this might be one of those few places where having the user explicitly pass in a list is also a reasonable and good option. What do you think?

[norakassner]

The implementation is done: you can have a look at it in my master branch. Right now you can distinguish between "alphabetically" (which is the default option to keep all plots created till now the same) and the other is "default" (maybe I should change the name here..?).

[ericmjl]

Woohoo!! Could you do a PR in? GitHub has some really nice features related to showing code diffs.

Btw, I've scanned the relevant parts of the codebase - it looks good! Don't forget to add in an example; I think I will start building the examples gallery over the next month or so.

[ericmjl]

Seeing as how #325 was merged, I'm closing this issue for now.