Helper classes in Swift about openwebrtc-examples

[jrosssavant]

Ok, I got the Swift example application working, and added the .swift helper classes and bridging header to the OwrHelpers directory. Was there anything else you had in mind for this task?

[stefanalund]

Thanks @jrosssavant, merged #29.

[jrosssavant]

No problem. I'm taking a look at SelfieSwift as well, but it's turning out to be a bit trickier. The best approach for this (and other native implementations) may be to create an Obj-C wrapper which can then be called from Swift.

[stefanalund]

Interesting. This is the design pattern Apple promotes for Swift <-> C++ interworking. What creates the problems, the callbacks?

[jrosssavant]

Yes, and the type mismatch messages it gives are sometimes unhelpful or misleading. I'll keep working on it for a bit. If I get stuck, I'll push a branch and let you take a look.

[jrosssavant]

After working on this a bit more, I can't seem to find a way to register a Swift function as a C function pointer callback. There are a number of StackOverflow topics that seem to confirm this is currently not possible:

http://stackoverflow.com/questions/25514176/using-swift-cfunctionpointer-to-pass-a-callback-to-coremidi-api
http://stackoverflow.com/questions/24107099/function-callback-from-c-to-swift
http://stackoverflow.com/questions/25346563/address-book-external-change-callback-in-swift-with-c-function-pointers

Until/if Apple updates Swift to support this, an Objective-C wrapper for these callbacks will most likely be required.

[jrosssavant]

I pushed the branch with my work here: https://github.com/jrosssavant/openwebrtc-examples/tree/selfie-swift-attempt, just in case you'd like to take a look.

[sentiasa]

Hi @jrosssavant, when I try to build your selfie-swift-attempt, I received:

/Users/Bertug/Downloads/openwebrtc-examples-selfie-swift-attempt/ios/OwrHelpers/OpenWebRTC-BridgingHeader.h:30:9: error: 'owr.h' file not found
#import "owr.h"
^
:0: error: failed to import bridging header '/Users/Bertug/Downloads/openwebrtc-examples-selfie-swift-attempt/ios/OwrHelpers/OpenWebRTC-BridgingHeader.h'

Am I doing something wrong or missing out something? Or did you stop working on it?

[superdump]

@sentiasa This example uses the OpenWebRTC.framework installed from the iOS package. If you have not installed it, owr.h will not be found. How are you trying to build it?

[superdump]

@sentiasa If you want to use the OpenWebRTC pod, try changing the include to <owr/owr.h>

[sentiasa]

@superdump When I followed "https://github.com/EricssonResearch/openwebrtc/wiki/Building-OpenWebRTC" this documentation, I have done everything successfully until 'Using the Results - iOS Framework' but when I installed openwebrtc-devel-0.1.0-ios-universal.pkg (just to clear that my file is devel-0.1.0-ios-universal.pkg rather than devel-0.3.0-ios-universal.pkgeven though I just updated) , no folder and files are created in ' ~/Library/Developer/OpenWebRTC/' in my case. So I ended up dragging the framework from Library/Frameworks/ and manually added into SelfieSwift demo. So I also stuck in adding the header because I don't have ~/Library/Developer/OpenWebRTC/iPhone.sdk/OpenWebRTC.framework/Headers either.

Then I gave up in the previous step and I tried the pod. However whatever I've tried, <owr/owr.h> cannot be found. Can I achieve what I am trying to achieve with podfile? Can you help me what I should write in the Podfile? But I want to highlight again that ~/Library/Developer/OpenWebRTC/iPhone.sdk/OpenWebRTC.framework/Headers folder doesn't exist for me whatever I have done.

Is there any simpler way for me to start this? Like creating a Podfile as same as I use to run NativeDemo? If so, what should I write in the Podfile? Again, NativeDemo works perfectly for me.

[jrosssavant]

@sentiasa: As you guessed I have not worked on the SelfieSwift app in some time, but it was working at the time I last committed (8f2ccaf). At that time the OpenWebRTC libraries were linked into the demo app under the assumption that the openwebrtc repository was fully built for iOS, and that the openwebrtc repository was adjacent to the openwebrtc-examples repository. It looks like some changes have been made since that time to use the OpenWebRTC.framework - which I think is a great step forward. But I can't tell you how to get the correct framework into ~/Library/Developer/OpenWebRTC/iPhone.sdk/; that framework is not present on my machine (nor even ~/Library/Developer/OpenWebRTC). @superdump: is there a set of instructions that describes how to build and install the OpenWebRTC framework into that location? I have an old cerbero-based build which installs into /Library/Frameworks/OpenWebRTC.framework, but not into ~/Library.

[superdump]

If you build the iOS package according to the build instructions and then install the the .pkg file as instructed, it will land there.

Another alternative is to move it to use cocoapods instead.

[superdump]

Oh, and the appropriate package file is available in the OpenWebRTC release.

[jrosssavant]

Thanks for pointing this out - I downloaded the .pkg from the release and now the SimpleDemoSwift project compiles just fine. I was trying to do the cerbero build from scratch but was running into this error when building the Mac OS X host build:

$ ./cerbero-uninstalled -c config/osx-x86-64.cbc package -f openwebrtc
...
checking for xmlcatalog... /Library/Frameworks/OpenWebRTC.framework/Versions/0.3/bin/xmlcatalog
checking for DocBook XML DTD V4.3 in XML catalog... not found
configure: error: could not find DocBook XML DTD V4.3 in XML catalog

[superdump]

That's something I broke yesterday and didn't manage to fix before I had to stop. First priority when I get to the office. 😄

[superdump]

I was getting this working: http://ericssonresearch.github.io/openwebrtc/docs/gtk-doc/dev/

[superdump]

The docbook issue should now be fixed.

[jrosssavant]

Thanks, after a pull the build completed successfully and generated the package as expected.