Comments (1)
I need to be very honest with you about this, but I want you to know that there's no meanness in anything I'm saying. I appreciate people using these scripts, and taking the time to try to improve upon them. But the thing here is that this doesn't really make an improvement.
Lemme explain why:
You've sent me a text file, not a pull request, with a bit of code that I want in there quoted out. I really don't want to have an "Azure branch" of this code with a section quoted out or deleted, because later if I make any changes, I have to remember to make them in two places. In other words, it's not a tenable situation for me as the maintainer of these scripts. It creates more work for me long term.
If you want to see an example of a good submission via pull request to get things cloud compatible, check out #57. It respects the differences between on-prem, Managed Instances, and Azure SQL DB, and it doesn't do it by just removing the parts that don't work in different places. It's handled dynamically like other parts of this script are, to conform with differences across SQL Server versions over time. You can see how I handle columns being present in some versions and not others.
Of course, if you want to write code like that (you can even copy bits from the pull request I linked to), I'd be happy to have it. You can also choose not to, and continue to use the script with parts quoted out that don't work for you. When new versions come out, you'll need to remember to remove that part again, but that's pretty minor.
I respect that learning stuff like GitHub can be confusing and time consuming, and you just might not have the resources to learn how to write code and create pull requests. Likewise, I don't have cloud SQL Server versions to test the changes and write them on my own.
Another alternative, assuming doing the coding yourself isn't in the cards, would be to open an issue here, and maybe someone with the right setup will come along and work on it. Feel free to open a new issue for that, and I'll leave it open for a while.
Thanks,
Erik
from darlingdata.
Related Issues (20)
- Add the ability to return queries only from procedures/functions; Display summary resource usage data by procedure/function HOT 1
- sp_QuickieStore - Adjust for UTC Timestamps Used in Query Store HOT 4
- Make block viewer go faster
- Block Viewer plans
- Querying WhoIsActive-table returns an error in SSMS HOT 1
- Sorting sp_QuickieStore output by total CPU instead of average CPU HOT 1
- Notes from Canada HOT 1
- Msg 105 Unclosed quotation mark after the character string '(data[@name="is_recompi'. HOT 6
- Syntax Error in the script HOT 1
- sp_HealthParser: Add xml deadlock report section
- sp_QuickieStore not returning expected runtime_stats records HOT 6
- sp_QuickieStore unexpected default @end_date HOT 4
- sp_QuickieStore - Count of executions across all plan ids? HOT 2
- sp_PressureDetector: configurable CPU percent details
- sp_HumanEventsBlockViewer: Add object schema to contentious object
- Given @days_back is always negative then this would always return @days_back HOT 1
- sp_HumanEventsBlockViewer - check if databases already have RCSI enabled in sys.databases
- sp_HumanEvents: logging the one-off runs to table HOT 5
- sp_LogHunter: Add search for CAL warning
- Log_Hunter additional parameters for not delete record HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from darlingdata.