#nullable -annotations not set for procedures about efcorepowertools

[ErikEJ]

@spaasis Yes, it looks like an ommision from when the Interface class was introduced. A PR? 😄

[spaasis]

@ErikEJ Alright, I'll attempt a fix. Now I know where to look ;)

[spaasis]

@ErikEJ Setting the actual annotation is simple enough, but how should this thing actually work..

If I have a proc with:

CREATE PROCEDURE [dbo].[USP_MyProc]
				@MyParam varchar(50) = NULL,

Then the generated interface is
Task<List<USP_MyProcResult>> USP_MyProcAsync(string MyParam, CancellationToken cancellationToken = default);

Note that string MyParam is not string? so the nullability of the param is currently not correctly set.
Is this a bug or intended behavior?

If it's intended, we could always set #nullable disable to signify that all parameters are nullable by default.

[spaasis]

And the implementation of the above proc:

            var parameterreturnValue = new SqlParameter
            {
                ParameterName = "returnValue",
                Direction = System.Data.ParameterDirection.Output,
                SqlDbType = System.Data.SqlDbType.Int,
            };

            var sqlParameters = new []
            {
                    ParameterName = "MyParam",
                    Size = 50,
                    Value = MyParam ?? Convert.DBNull,
                    SqlDbType = System.Data.SqlDbType.VarChar,
                },

[ErikEJ]

Good question - all paramters are always nullable.

[spaasis]

@ErikEJ okay, so it should be sufficient then to just hardcode the #nullable disable in these two files. I'll have a PR up soon

[ErikEJ]

Correct

[ErikEJ]

Wonder why no one else has reported this?

[spaasis]

I wondered about the same thing.. Possibly the combination of nullable reference types + stored procs is rare?