Table Valued Parameters in Stored Procedures from a .dacpac about efcorepowertools

[ErikEJ]

I only recently implemented support for stored procedure discovery with a .dacpac, so I am hoping this is just a feature gap. If it is urgent for you I accept sponsorships! 😄

[HAK-Logos]

@ErikEJ Works like a charm 😄

Again, thank you!

[ErikEJ]

Correct, that is not supported, but can you provide a proper repro, you should see a message like this in the outptu window, not an error like above:

Unable to scaffold FUNCTION 'dbo.FuncWithTvpParameter' as it has TVP parameters.

[HAK-Logos]

Thanks for quick reply!
I'll try to setup a repro soon and link it to you.

[HAK-Logos]

Out of curiosity, will TVP be implemented in the future?

[ErikEJ]

Out of curiosity, will TVP be implemented in the future?

You can map a tvp returning function today.

But how would you manually code a call using a TVP parameter today (using ADO.NET fo example) ?

[ErikEJ]

@HAK-Logos Sorry! Actually, the error above is from Functions with tvp parameters - as far as I can see, stored procedure tvp parameters should be supported (as DataTable), but there could be a regression and I am lacking a good sample for my regression test!

[HAK-Logos]

Good, then I'm not going crazy. I was wondering why you were referring to Functions :-)

So it is possible to include TVP in Stored Procedures, but I'm getting the above error.
Is there anything I can do to help you locate the issue?

Just for reference, this is the code where it throws the exception:
https://github.com/ErikEJ/EFCorePowerTools/blob/master/src/Core/RevEng.Core.60/Routines/Extensions/SqlServerSqlTypeExtensions.cs

[ErikEJ]

I can see that you should NOT be using "legacyResultSetDiscovery" in order for the parameters to be discovered.

For help, please provide a runnable set of SQL scripts that creates the required objects and I can step through the code.

[HAK-Logos]

Here's a script for the user defined type:

CREATE TYPE [dbo].[IntegerList] AS TABLE(
[I] INT NOT NULL,
PRIMARY KEY CLUSTERED ([I] ASC)
);

And here's a sproc:

CREATE PROCEDURE [dbo].[SomeStoredProcedure]
@SomeParameter1 BIGINT,
@SomeParameterList1 [dbo].[IntegerList] READONLY
AS
BEGIN
SET XACT_ABORT ON
SELECT 1
END

Is that enough?

[ErikEJ]

@HAK-Logos Yes! And does that cause the error you listed above?

[HAK-Logos]

Yes, it should

[ErikEJ]

@HAK-Logos But it does not! Please provide a repro that actually causes the error you reported above.

public virtual async Task<List<SomeStoredProcedureResult>> SomeStoredProcedureAsync(long? SomeParameter1, DataTable SomeParameterList1, OutputParameter<int> returnValue = null, CancellationToken cancellationToken = default)
        {
            var parameterreturnValue = new SqlParameter
            {
                ParameterName = "returnValue",
                Direction = System.Data.ParameterDirection.Output,
                SqlDbType = System.Data.SqlDbType.Int,
            };

            var sqlParameters = new []
            {
                new SqlParameter
                {
                    ParameterName = "SomeParameter1",
                    Value = SomeParameter1 ?? Convert.DBNull,
                    SqlDbType = System.Data.SqlDbType.BigInt,
                },
                new SqlParameter
                {
                    ParameterName = "SomeParameterList1",
                    Value = SomeParameterList1 ?? Convert.DBNull,
                    SqlDbType = System.Data.SqlDbType.Structured,
                    TypeName = "[dbo].[IntegerList]",
                },
                parameterreturnValue,
            };
            var _ = await _context.SqlQueryAsync<SomeStoredProcedureResult>("EXEC @returnValue = [dbo].[SomeStoredProcedure] @SomeParameter1 = @SomeParameter1, @SomeParameterList1 = @SomeParameterList1", sqlParameters, cancellationToken);

            returnValue?.SetValue(parameterreturnValue.Value);

            return _;
        }

[HAK-Logos]

Intriguing.. Let me setup a project that replicates the issue and link it to you. Unfortunately I can't link the current project to you. It might take some time, but I will get back to you.

[ErikEJ]

Ah, I missed this "Is a SQL Server .dacpac used: yes" 😄

[ErikEJ]

Potentially not supported (yet) with a .dacpac

[HAK-Logos]

Oh fair enough, that's alright 😄

Sorry, had to remove my previous comment. Uploaded the wrong .zip file.

Here's the right one.

EFCPT.zip

[HAK-Logos]

Potentially not supported (yet) with a .dacpac

So only potentially, that's better than "not supported" 😄

I hope it's not that big of a deal to make it work, otherwise I have to put this branch on hold for now.

We are changing some "old" code from passing comma separated strings to SQL, to now use TVP. Converting that string to something edible in SQL is kind of performance heavy, when we pass around 10k values.. So it would be nice to have this working 🙂

[ErikEJ]

Workaround would be to publish the .dacpac a generate code from the published database

[HAK-Logos]

Workaround would be to publish the .dacpac a generate code from the published database

Hmm.. That is a solution, but I just don't see it being practical in a live environment, fully integrated with CI/CD.

Do you already know, what is required for TVP to be compatible with .dacpac? Or if you're planning to implement it in the near future? 🙂

[HAK-Logos]

I understand 😉 I will get back to you sooner or later!

Anyways, thanks for the help for now 👍

[ErikEJ]

I implemented a fix for this in the latest daily build, would be grateful if you could try it out.

If you like my free tools, I would be very grateful for a rating or review on Visual Studio Marketplace or even a one-time or monthly sponsorship

[HAK-Logos]

Well that was fast 😄

I appreciate it! And ofc. I'll as a minimum review your tool.

Have a great evening 🙂