GithubHelp home page GithubHelp logo

Comments (3)

erincatto avatar erincatto commented on July 2, 2024 2

Thanks for reporting this.

This is a required aspect of the solver. The first dv is used to compute the normal impulse. After that is applied dv needs to be updated for the tangent (friction) impulse. I recommend you try removing the second computation and see how the solver behaves.

from box2d-lite.

erincatto avatar erincatto commented on July 2, 2024 1

Thanks, fixed in 3e3dccb

from box2d-lite.

lch32111 avatar lch32111 commented on July 2, 2024

Thanks for answering this. I get to know now why it is there.

And I have one more to report to you.

box2d-lite/src/Collide.cpp

Lines 170 to 171 in d970582

Vec2 a1 = RotA.col1, a2 = RotA.col2;
Vec2 b1 = RotB.col1, b2 = RotB.col2;

On int Collide(Contact* contacts, Body* bodyA, Body* bodyB) function,
you define each col of rotation matrices from bodyA and bodyB.
But you don't use it.

I know it does not affect the performance and the behavior of box2d.
But I just want to clear it.

from box2d-lite.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.