`q` and `cp` broadcasting smells about calcbsimpvol

[erkandem]

Hey @gregdesu ,

Glad to hear the Python version is used! Thank you for using it.
On the issue: I think you're right. if size(q): and if size(cp): do not make much sense. It never error-ed because I always supplied everything in vector format. ... and there is "no" test coverage :$.
Please open a New Issue for that (copy paste your message above into a new thread - ok I found a way to use your initial comment).

kind regards
Erkan

[gregdesu]

👍 awesome. Thank you for taking a look at it. To allow passing single maturities when vector is 2 dims with shape (1, n), I modified line 167 with: if *(*len(shape(arg_dict[key])) == 1 *or 1 in shape(arg_dict[key]))* and key is not 'S': best, Greg

…

On Wed, Apr 8, 2020 at 3:55 PM Erkan Demiralay ***@***.***> wrote: Closed #2 <#2> via 1cd7543 <1cd7543> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOCW7M4OLI6VOZUMQKASIP3RLTJC5ANCNFSM4MCMQ27A> .

[erkandem]

+1 awesome. Thank you for taking a look at it.

your welcome. everybody profits from reporting smells, issues and bugs.

To allow passing single maturities when vector is 2 dims with shape (1, n), I modified line 167 with: if *(*len(shape(arg_dict[key])) == 1 or 1 in shape(arg_dict[key])) and key is not 'S':

In my own words: Script should account for row-vectors just like column vectors?

Could you share an example ..or two? I'd also assume now we are talking about sth. else than futures.