GithubHelp home page GithubHelp logo

Comments (13)

ericbmerritt avatar ericbmerritt commented on August 22, 2024

@bit just a quick question. Are you using common test?

from relx.

blt avatar blt commented on August 22, 2024

@ericbmerritt We do, yes, for fe_api and fire_engine. The suites themselves are placed in the apps/APP/itest directory and the applications' logs are in apps/APP/logs.

from relx.

blt avatar blt commented on August 22, 2024

@ericbmerritt I had a chance to look into this more today. After deleting all the CT log files--which we've got stored in the app/*logs/ directories and of which we'd accumulated quite a bit--relx ran without issue.

from relx.

ericbmerritt avatar ericbmerritt commented on August 22, 2024

Brian,

Yes, that is the problem. But really, relx shouldn't be looking in those
directories. There is no reason to try to discover apps in the log dir and
its a rather common error. I am going to work on adding a patch that stops
this behaviour.

Eric

On Tue, Aug 20, 2013 at 12:59 PM, Brian L. Troutwine <
[email protected]> wrote:

@ericbmerritt https://github.com/ericbmerritt I had a chance to look
into this more today. After deleting all the CT log files--which we've got
stored in the app/*logs/ directories and of which we'd accumulated quite a
bit--relx ran without issue.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-22973112
.

from relx.

blt avatar blt commented on August 22, 2024

Neat; thank you. relx is also looking in .git directories, for that matter.

from relx.

tsloughter avatar tsloughter commented on August 22, 2024

This is still an issue right? @ericbmerritt the plan should be to ignore certain directories, as opposed to only searching certain directories, right? Since we don't know what their name their deps dir, their apps dir, they may have multiple releases with different output directories in their project like github.com/extend/elevators.

from relx.

tsloughter avatar tsloughter commented on August 22, 2024

@ericbmerritt never got a reply on this?

from relx.

ericbmerritt avatar ericbmerritt commented on August 22, 2024

Well, the goal is that instead of searching everything in ./ we only look for specific relevant directories. deps, ebin, whatever the release output dir is. Though that has caused problems in and of itself.

from relx.

tsloughter avatar tsloughter commented on August 22, 2024

I guess we could just do apps deps andebin` plus allowing defining additional paths in the config file.

from relx.

ericbmerritt avatar ericbmerritt commented on August 22, 2024

yea, for app discovery. Then release discovery can happen as it does. It
still needs to look in everything more or less. While skipping the log
dirs.

Maybe for app discovery it goes ebin, deps, apps, lib, lib dirs and
for release its release output dir, _rel, rel, lib dirs

On Wed, Sep 18, 2013 at 10:01 AM, Tristan Sloughter <
[email protected]> wrote:

I guess we could just do apps deps andebin` plus allowing defining
additional paths in the config file.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-24681357
.

from relx.

tsloughter avatar tsloughter commented on August 22, 2024

@ericbmerritt I'm confused now actually. How/when is it looking in .git? And there isn't anything we can change the issue with it looking in ./apps/*logs/... And if it is looking in .git that is a bug somewhere that should be easy to fix. We already limit where it looks for apps:

            Apps = filename:join(Root, "apps"),
            Lib = filename:join(Root, "lib"),
            Deps = filename:join(Root, "deps"),
            Ebin = filename:join(Root, "ebin"),

from relx.

tsloughter avatar tsloughter commented on August 22, 2024

Oh but for things like deps it will... Is that the issue? Do we want to filter the dirs we go to when we recurse into directories like ./deps?

from relx.

jwilberding avatar jwilberding commented on August 22, 2024

Going to close this as #101 took care of it.

from relx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.