Setting SVG viewBox attribute about react-d3

[esbullington]

This is an excellent point. We can set the viewBox and let the chart user set the parent component's width and height. That should work well.

Only possible issue is IE9+. Seems like I remember some cross-browser issues with viewBox that have made me just use resize events in the past.

Either way, I'll definitely expose it to the user.

[jxnblk]

Great, thanks! 💥

At least for my use-case with internal tools, we only support Chrome and Firefox, so I could definitely use this.

[jmuel]

Has there been progress on this? If there hasn't is there anything I can do to help?

[esbullington]

Yes, it's been merged to master with the 0.3 branch, but not yet published to NPM. I've been quite sick for several weeks with a bad case of the flu, and I'm just now catching up on stuff.

Anyway, if you're using the Github repo, you can set the SVG viewBox string on any of the Cartesian-coordinate charts (ie, scatter, line, and candle charts at this point). Not well tested, so let me know if you have any problems. That would actually be a big help.

I hope to have 0.3 published to NPM in the next few days after I test out some of the new features.

[jmuel]

Thanks. I'll probably wait for the npm release but if I get bored I'll play around with the current branch.

[yang-wei]

@jmuel We forget to refer to this issue when we solved this. But I suppose https://github.com/esbullington/react-d3/blob/master/src%2Fcommon%2Fcharts%2FBasicChart.jsx#L11

[jmuel]

Thanks, that looks like it should do it.