Bug: `unsupported-features/node-builtins-modules` doesn't work for semver range in v17 about eslint-plugin-n

[aladdin-add]

yes, the configured version should be a subset of the supported range. I have made a fix: #252

[scagood]

Thank you for this report!

We have two options here:

1. Convert the range to a minimum version
2. Throw an error to state that the config must not be a version range

I think in this context that converting it to a minimum version is the best course of action.

What do you think @aladdin-add?

[teppeis]

2. Throw an error to state that the config must not be a version range

What about the engines field of package.json? Mostly range is used there.

1. Convert the range to a minimum version

When the engines field is >=18.10.0 || >= 20.0.0, it should be converted to 18.10.0 ? When supported versions are ["20.1.0", "18.9.0"], it cannot be determined whether it is supported using the minimum version.

It would be better to use the same logic as before.
https://github.com/eslint-community/eslint-plugin-n/blob/16.6.2/lib/util/check-unsupported-builtins.js#L54-L60

[scagood]

The same section you highlighted can be found here on master:
https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/util/check-unsupported-builtins.js#L40-L47

[teppeis]

The difference:

• v16: return !configured.intersects(unsupportedRange) (configured is expected to be range)
• v17: return configured.intersects(supportedRange)　(configured is expected to be only minimum version)

[scagood]

A fix was implemented in #252, but due to an issue in semver we needed to revert it.

For now I wonder if we can solve this another way 🤔