why is n/file-extension-in-import a stylic? about eslint-plugin-n

[scagood]

If we want to convert n/file-extension-in-import to a recommended rule, can we create another issue for this please? 🙏

[aladdin-add]

well, I think it's time to rethink the rule. It was written when the node.js esm was not stabilized. Nowadays it's stabilized in node v12. time to make some changes.

1. renaming to file-extension, and also check requires(common.js). the rule was only checking imports. but some devs may still want to use file extensions for some reasons.

2. more configurable(easy to adopt if using ts/babel/esbuild/...):

"n/file-extension": [2, { "requires": "always", "imports": "always"}

3. recommended preset changes:

   a. recommended-script:

"n/file-extension": [2, { "requires": "never"}

b. recommended-module:

"n/file-extension": [2, { "requires": "always", "imports": "always"}

[aladdin-add]

do you mean the meta.docs.category?
https://github.com/weiran-zsd/eslint-plugin-node/blob/d7b975a07e1b876ca2c75597d054a81564b25685/lib/rules/file-extension-in-import.js#L40

it's not actually used anywhere, and eslint has removed it in all its core rules.

[jimmywarting]

I think both of import(x) and require(x) should by default require file extensions

It don't hurt to use extension in CommonJS too. in fact it makes things faster to lookup and also easier for build tools to not having to 2nd guess what you meant to import. it only complicates things further and they need to apply to the same rule as node.js resolve algoritm over at: https://nodejs.org/dist/latest-v18.x/docs/api/modules.html#all-together (which is just insane)
Ryan dhal regretted all of it and it is not how the web/esm works.

more and more ppl are switching over to esm and refactor cjs to esm is no easy task as just simply switching out all require calls to import() and using the same path. it needs to solve the path to index.js as well.
If things where just require('./index.js') then it would be as simple as just changing it to an import statement and makeing an auto fix would be easier to write.

After reading The cost of many small modules i made a bench test that tried to require many files with and without file extension and using index.js vs just a normal name such as mod.js
And the script loaded faster if the path was more explicit as it did not have to stat files/folder to look up as many files to quickly figuring out what you ment to import

[aladdin-add]

well, perf is a good point, but IMHO it do hurt DX. afaict, most node.js devs(like me lol.) are used to not writing it.

please note it's just a default, and it cannot meet everyone's wants. If it does not, you can always add your own config to overwrite it. 😄